From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751454AbdA2X4y (ORCPT ); Sun, 29 Jan 2017 18:56:54 -0500 Received: from casper.infradead.org ([85.118.1.10]:33686 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbdA2X4r (ORCPT ); Sun, 29 Jan 2017 18:56:47 -0500 Date: Sun, 29 Jan 2017 23:56:38 +0000 (GMT) From: James Simmons To: Joe Perches cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Linux Kernel Mailing List , Lustre Development List , James Simmons Subject: Re: [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs to proper structure In-Reply-To: <1485205276.12563.30.camel@perches.com> Message-ID: References: <1485045632-5886-1-git-send-email-jsimmons@infradead.org> <1485205276.12563.30.camel@perches.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170129_235638_505989_C0CF4719 X-CRM114-Status: GOOD ( 10.29 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Sat, 2017-01-21 at 19:40 -0500, James Simmons wrote: > > The upstream kernel requires proper structures so > > convert nearly all the LNet wire protocols typedefs in > > the LNet core. > > Thanks. > > Perhaps s/\bWIRE_ATTR\b/__packed/g one day too I liked to keep that one. The point of WIRE_ATTR isn't to be some abstraction but to label that struct as something that goes over the wire. This lets people know that it would break something if you change that structure. Looks like I need to send a patch that adds a comment explaning the meaning of WIRE_ATTR. From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Simmons Date: Sun, 29 Jan 2017 23:56:38 +0000 (GMT) Subject: [lustre-devel] [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs to proper structure In-Reply-To: <1485205276.12563.30.camel@perches.com> References: <1485045632-5886-1-git-send-email-jsimmons@infradead.org> <1485205276.12563.30.camel@perches.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Linux Kernel Mailing List , Lustre Development List , James Simmons > On Sat, 2017-01-21 at 19:40 -0500, James Simmons wrote: > > The upstream kernel requires proper structures so > > convert nearly all the LNet wire protocols typedefs in > > the LNet core. > > Thanks. > > Perhaps s/\bWIRE_ATTR\b/__packed/g one day too I liked to keep that one. The point of WIRE_ATTR isn't to be some abstraction but to label that struct as something that goes over the wire. This lets people know that it would break something if you change that structure. Looks like I need to send a patch that adds a comment explaning the meaning of WIRE_ATTR.