All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Ott <sebott@linux.vnet.ibm.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7
Date: Tue, 27 Mar 2018 10:41:45 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.21.1803271037410.1726@schleppi> (raw)
In-Reply-To: <CAMuHMdX_aTqi=8FmBR07K6-C=ycCrPQ+dT=ujXzNTcekdXB5ag@mail.gmail.com>

Hello Geert,

On Tue, 27 Mar 2018, Geert Uytterhoeven wrote:
> On Tue, Mar 27, 2018 at 10:12 AM, Sebastian Ott
> <sebott@linux.vnet.ibm.com> wrote:
> > commit 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 broke usage of dma
> > allocations specifying __GFP_ZERO by silently removing that flag.
> 
> How did it break? The flag is now always added.

+       flag &= ~(__GFP_DMA | __GFP_DMA32 | __GFP_HIGHMEM | __GFP_ZERO);

I read that as a removal. But maybe I need more coffee..

Sebastian

  reply	other threads:[~2018-03-27  8:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27  8:12 dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 Sebastian Ott
2018-03-27  8:21 ` Geert Uytterhoeven
2018-03-27  8:41   ` Sebastian Ott [this message]
2018-03-27  8:51     ` Geert Uytterhoeven
2018-03-27 14:33 ` Christoph Hellwig
2018-03-27 15:24   ` Sebastian Ott
2018-03-27 16:45     ` Christoph Hellwig
2018-03-27 17:04       ` Sebastian Ott
2018-03-28 11:57         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.21.1803271037410.1726@schleppi \
    --to=sebott@linux.vnet.ibm.com \
    --cc=geert@linux-m68k.org \
    --cc=hch@lst.de \
    --cc=jesper.nilsson@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.