From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git Mailing list <git@vger.kernel.org>
Subject: Re: should config options be treated as case-sensitive?
Date: Tue, 22 May 2018 12:33:50 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.21.1805221231480.10513@localhost.localdomain> (raw)
In-Reply-To: <87h8mz99d2.fsf@evledraar.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]
On Tue, 22 May 2018, Ævar Arnfjörð Bjarmason wrote:
>
> On Tue, May 22 2018, Robert P. J. Day wrote:
>
> > in my wanderings, more oddities, such as this:
> >
> > $ grep -ir blankboundary *
> > builtin/blame.c: if (!strcmp(var, "blame.blankboundary")) {
> > Documentation/config.txt:blame.blankBoundary::
> > Documentation/blame-options.txt: be controlled via the `blame.blankboundary` config option.
> > Documentation/RelNotes/2.15.1.txt: * Description of blame.{showroot,blankboundary,showemail,date}
> > Documentation/RelNotes/2.16.0.txt: * Description of blame.{showroot,blankboundary,showemail,date}
> > $
> >
> > where you can see the single instance of "blankBoundary" in
> > Doc/config.txt (with the upper case 'B'), while the rest have no such
> > thing.
> >
> > for fun, i checked another of blame's config settings, with similar
> > results:
> >
> > builtin/blame.c: if (!strcmp(var, "blame.showemail")) {
> > Documentation/config.txt:blame.showEmail::
> > Documentation/RelNotes/2.15.1.txt: * Description of blame.{showroot,blankboundary,showemail,date}
> > Documentation/RelNotes/2.5.0.txt: * "git blame" learned blame.showEmail configuration variable.
> > Documentation/RelNotes/2.16.0.txt: * Description of blame.{showroot,blankboundary,showemail,date}
> > Documentation/git-blame.txt: This can also be controlled via the `blame.showEmail` config
> > t/t8002-blame.sh:test_expect_success 'setup showEmail tests' '
> > t/t8002-blame.sh:test_expect_success 'blame with showemail options' '
> > t/t8002-blame.sh:test_expect_success 'blame with showEmail config false' '
> > t/t8002-blame.sh: git config blame.showEmail false &&
> > t/t8002-blame.sh:test_expect_success 'blame with showEmail config true' '
> > t/t8002-blame.sh: git config blame.showEmail true &&
> >
> > thoughts?
>
> The issues you note about the docs using foo.barbaz instead of
> foo.barBaz should be fixed, but as noted in the "Syntax" section of
> "git-config" we already document that the config keys are all
> case-insensitive. We just like talking about them as foo.barBaz
> because it makes for easier reading.
ah, got it, so really, the only example above that would merit
tweaking would be:
blame-options.txt: be controlled via the `blame.blankboundary` config option.
i'll collect those in my travels and submit them all at once.
rday
next prev parent reply other threads:[~2018-05-22 16:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 7:57 should config options be treated as case-sensitive? Robert P. J. Day
2018-05-22 12:13 ` Ævar Arnfjörð Bjarmason
2018-05-22 16:33 ` Robert P. J. Day [this message]
2018-05-23 1:55 ` Junio C Hamano
2018-05-23 7:59 ` Robert P. J. Day
2018-05-23 8:58 ` Junio C Hamano
2018-05-23 9:04 ` Robert P. J. Day
2018-05-23 23:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1805221231480.10513@localhost.localdomain \
--to=rpjday@crashcourse.ca \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.