From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 22 Nov 2018 17:31:20 +0100 (CET) Received: (from localhost user: 'macro', uid#1010) by eddie.linux-mips.org with ESMTP id S23992492AbeKVQbN60Bwv (ORCPT ); Thu, 22 Nov 2018 17:31:13 +0100 Date: Thu, 22 Nov 2018 16:31:13 +0000 (GMT) From: "Maciej W. Rozycki" To: Paul Burton cc: "linux-mips@linux-mips.org" , Paul Burton Subject: Re: [PATCH 2/7] MIPS: Remove unused PIC macros In-Reply-To: <20181015183304.16782-3-paul.burton@mips.com> Message-ID: References: <20181015183304.16782-1-paul.burton@mips.com> <20181015183304.16782-3-paul.burton@mips.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 67457 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: macro@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Mon, 15 Oct 2018, Paul Burton wrote: > asm/asm.h contains CPRESTORE, CPADD & CPLOAD macros that are intended > for use with position independent code, but are not used anywhere in the > kernel - along with a comment to that effect. Remove the dead code. FYI, this was I believe for consistency with the glibc header and in the days since lost in the mist to time may have actually been used by the userland too. Overall the contents of this header used to be somewhat standardised in a platform-independent way, e.g. the IDT MIPS software manual says[1]: "Many toolchains supply a header file , which provides C-style macros to generate the appropriate directives, as required [...]" and then goes on to use across the many snippets of code included throughout. References: [1] "IDT MIPS Microprocessor Family Software Reference Manual", Integrated Device Technology, Inc., Version 2.0, October 1996, Chapter 9 "Assembler Language Programming", p. 9-17 [Yes, it did have a chapter on the MIPS assembly language, including the syntax, which some people confuse with the syntax architecture manuals use for the instruction set.] Maciej