* [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
@ 2019-02-05 16:01 Yang Wei
2019-02-05 19:57 ` Maciej W. Rozycki
2019-02-07 1:42 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Yang Wei @ 2019-02-05 16:01 UTC (permalink / raw)
To: netdev; +Cc: macro, davem, yang.wei9, albin_yang
From: Yang Wei <yang.wei9@zte.com.cn>
dev_consume_skb_irq() should be called in dfx_xmt_done() when skb
xmit done. It makes drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
---
drivers/net/fddi/defxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c
index 38ac8ef..56b7791 100644
--- a/drivers/net/fddi/defxx.c
+++ b/drivers/net/fddi/defxx.c
@@ -3512,7 +3512,7 @@ static int dfx_xmt_done(DFX_board_t *bp)
bp->descr_block_virt->xmt_data[comp].long_1,
p_xmt_drv_descr->p_skb->len,
DMA_TO_DEVICE);
- dev_kfree_skb_irq(p_xmt_drv_descr->p_skb);
+ dev_consume_skb_irq(p_xmt_drv_descr->p_skb);
/*
* Move to start of next packet by updating completion index
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
2019-02-05 16:01 [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Yang Wei
@ 2019-02-05 19:57 ` Maciej W. Rozycki
2019-02-06 15:13 ` albin_yang
2019-02-07 1:42 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Maciej W. Rozycki @ 2019-02-05 19:57 UTC (permalink / raw)
To: Yang Wei; +Cc: netdev, David S. Miller, yang.wei9
On Wed, 6 Feb 2019, Yang Wei wrote:
> From: Yang Wei <yang.wei9@zte.com.cn>
>
> dev_consume_skb_irq() should be called in dfx_xmt_done() when skb
> xmit done. It makes drop profiles(dropwatch, perf) more friendly.
>
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>
It looks to me the driver has to be reviewed WRT `dev_kfree_skb' vs
`kfree_skb' use too. I'll have a look into it unless you are happy to do
that.
Thanks for your contribution!
Maciej
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re:Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
2019-02-05 19:57 ` Maciej W. Rozycki
@ 2019-02-06 15:13 ` albin_yang
0 siblings, 0 replies; 4+ messages in thread
From: albin_yang @ 2019-02-06 15:13 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: netdev, David S. Miller, yang.wei9
At 2019-02-06 03:57:34, "Maciej W. Rozycki" <macro@linux-mips.org> wrote:
>On Wed, 6 Feb 2019, Yang Wei wrote:
>
>Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>
>
> It looks to me the driver has to be reviewed WRT `dev_kfree_skb' vs
>`kfree_skb' use too. I'll have a look into it unless you are happy to do
>that.
>
> Thanks for your contribution!
>
Hi, Maciej
I think kfree_skb() should be called when skb is dropped by network drivers.
I found that many network drivers have such problems that not use
kfree_skb/consume_skb properly. Maybe because 'drop profiles' appears later
than many network drivers?
The problem 'dev_kfree_skb' vs 'kfree_skb' should be fixed. I think that is
lower priority than the current patch. Network driver should not perturb
drop profiles when skb successful xmit.
Thanks
Yang
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
2019-02-05 16:01 [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Yang Wei
2019-02-05 19:57 ` Maciej W. Rozycki
@ 2019-02-07 1:42 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2019-02-07 1:42 UTC (permalink / raw)
To: albin_yang; +Cc: netdev, macro, yang.wei9
From: Yang Wei <albin_yang@163.com>
Date: Wed, 6 Feb 2019 00:01:04 +0800
> From: Yang Wei <yang.wei9@zte.com.cn>
>
> dev_consume_skb_irq() should be called in dfx_xmt_done() when skb
> xmit done. It makes drop profiles(dropwatch, perf) more friendly.
>
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-07 1:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-05 16:01 [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Yang Wei
2019-02-05 19:57 ` Maciej W. Rozycki
2019-02-06 15:13 ` albin_yang
2019-02-07 1:42 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.