From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F4CC433FF for ; Mon, 29 Jul 2019 20:20:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D8B02064C for ; Mon, 29 Jul 2019 20:20:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729279AbfG2UUg (ORCPT ); Mon, 29 Jul 2019 16:20:36 -0400 Received: from ja.ssi.bg ([178.16.129.10]:52836 "EHLO ja.ssi.bg" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729250AbfG2UUg (ORCPT ); Mon, 29 Jul 2019 16:20:36 -0400 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by ja.ssi.bg (8.15.2/8.15.2) with ESMTP id x6TKK6AN006015; Mon, 29 Jul 2019 23:20:06 +0300 Date: Mon, 29 Jul 2019 23:20:06 +0300 (EEST) From: Julian Anastasov To: Florian Westphal cc: hujunwei , wensong@linux-vs.org, horms@verge.net.au, pablo@netfilter.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, Mingfangsen , wangxiaogang3@huawei.com, xuhanbing@huawei.com Subject: Re: [PATCH net] ipvs: Improve robustness to the ipvs sysctl In-Reply-To: <20190729004958.GA19226@strlen.de> Message-ID: References: <1997375e-815d-137f-20c9-0829a8587ee9@huawei.com> <20190729004958.GA19226@strlen.de> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hello, On Mon, 29 Jul 2019, Florian Westphal wrote: > > diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c > > index 741d91aa4a8d..e78fd05f108b 100644 > > --- a/net/netfilter/ipvs/ip_vs_ctl.c > > +++ b/net/netfilter/ipvs/ip_vs_ctl.c > > @@ -1680,12 +1680,18 @@ proc_do_defense_mode(struct ctl_table *table, int write, > > int val = *valp; > > int rc; > > > > - rc = proc_dointvec(table, write, buffer, lenp, ppos); > > + struct ctl_table tmp = { > > + .data = &val, > > + .maxlen = sizeof(int), > > + .mode = table->mode, > > + }; > > + > > + rc = proc_dointvec(&tmp, write, buffer, lenp, ppos); > > Wouldn't it be better do use proc_dointvec_minmax and set the > constraints via .extra1,2 in the sysctl knob definition? We store the 'ipvs' back-ptr in extra2, so may be we can not use it in the table for proc_do_defense_mode, only for tmp. proc_do_sync_mode may use extra1/2 in table for the proc_dointvec_minmax call. Regards -- Julian Anastasov