* [PATCH] ipvs: change type of delta and previous_delta in ip_vs_seq.
@ 2019-08-20 0:37 zhang kai
2019-08-20 10:00 ` Julian Anastasov
0 siblings, 1 reply; 3+ messages in thread
From: zhang kai @ 2019-08-20 0:37 UTC (permalink / raw)
To: wensong, horms, ja, davem, kuznet, yoshfuji; +Cc: lvs-devel, netdev
In NAT forwarding mode, Applications may decrease the size of packets,
and TCP sequences will get smaller, so both of variables will be negetive
values in this case.
Signed-off-by: zhang kai <zhangkaiheb@126.com>
---
include/net/ip_vs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
index 3759167f91f5..de7e75063c7c 100644
--- a/include/net/ip_vs.h
+++ b/include/net/ip_vs.h
@@ -346,8 +346,8 @@ enum ip_vs_sctp_states {
*/
struct ip_vs_seq {
__u32 init_seq; /* Add delta from this seq */
- __u32 delta; /* Delta in sequence numbers */
- __u32 previous_delta; /* Delta in sequence numbers
+ __s32 delta; /* Delta in sequence numbers */
+ __s32 previous_delta; /* Delta in sequence numbers
* before last resized pkt */
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipvs: change type of delta and previous_delta in ip_vs_seq.
2019-08-20 0:37 [PATCH] ipvs: change type of delta and previous_delta in ip_vs_seq zhang kai
@ 2019-08-20 10:00 ` Julian Anastasov
0 siblings, 0 replies; 3+ messages in thread
From: Julian Anastasov @ 2019-08-20 10:00 UTC (permalink / raw)
To: zhang kai; +Cc: Wensong Zhang, Simon Horman, lvs-devel, netdev
Hello,
Cc list trimmed...
On Tue, 20 Aug 2019, zhang kai wrote:
> In NAT forwarding mode, Applications may decrease the size of packets,
> and TCP sequences will get smaller, so both of variables will be negetive
> values in this case.
As long as nobody cares about their sign, the type should not
matter. You can not solve all signed/unsigned mismatches with such
small patch. Or you are seeing some problem, may be in debug?
>
> Signed-off-by: zhang kai <zhangkaiheb@126.com>
> ---
> include/net/ip_vs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
> index 3759167f91f5..de7e75063c7c 100644
> --- a/include/net/ip_vs.h
> +++ b/include/net/ip_vs.h
> @@ -346,8 +346,8 @@ enum ip_vs_sctp_states {
> */
> struct ip_vs_seq {
> __u32 init_seq; /* Add delta from this seq */
> - __u32 delta; /* Delta in sequence numbers */
> - __u32 previous_delta; /* Delta in sequence numbers
> + __s32 delta; /* Delta in sequence numbers */
> + __s32 previous_delta; /* Delta in sequence numbers
> * before last resized pkt */
> };
>
> --
> 2.17.1
Regards
--
Julian Anastasov <ja@ssi.bg>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ipvs: change type of delta and previous_delta in ip_vs_seq.
@ 2019-08-20 10:00 ` Julian Anastasov
0 siblings, 0 replies; 3+ messages in thread
From: Julian Anastasov @ 2019-08-20 10:00 UTC (permalink / raw)
To: zhang kai; +Cc: Wensong Zhang, Simon Horman, lvs-devel, netdev
Hello,
Cc list trimmed...
On Tue, 20 Aug 2019, zhang kai wrote:
> In NAT forwarding mode, Applications may decrease the size of packets,
> and TCP sequences will get smaller, so both of variables will be negetive
> values in this case.
As long as nobody cares about their sign, the type should not
matter. You can not solve all signed/unsigned mismatches with such
small patch. Or you are seeing some problem, may be in debug?
>
> Signed-off-by: zhang kai <zhangkaiheb@126.com>
> ---
> include/net/ip_vs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
> index 3759167f91f5..de7e75063c7c 100644
> --- a/include/net/ip_vs.h
> +++ b/include/net/ip_vs.h
> @@ -346,8 +346,8 @@ enum ip_vs_sctp_states {
> */
> struct ip_vs_seq {
> __u32 init_seq; /* Add delta from this seq */
> - __u32 delta; /* Delta in sequence numbers */
> - __u32 previous_delta; /* Delta in sequence numbers
> + __s32 delta; /* Delta in sequence numbers */
> + __s32 previous_delta; /* Delta in sequence numbers
> * before last resized pkt */
> };
>
> --
> 2.17.1
Regards
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-20 10:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 0:37 [PATCH] ipvs: change type of delta and previous_delta in ip_vs_seq zhang kai
2019-08-20 10:00 ` Julian Anastasov
2019-08-20 10:00 ` Julian Anastasov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.