From: "Maciej W. Rozycki" <macro@wdc.com>
To: Huacai Chen <chenhc@lemote.com>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"open list:MIPS" <linux-mips@vger.kernel.org>,
Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH] MIPS: inst.h: Stop including asm.h to avoid various build failures
Date: Thu, 14 May 2020 13:23:33 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.2005141316390.6492@redsun52.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <CAAhV-H63n_wa8Z72WRNPjeG0aVYEujvcDJPmd2nPcER1NrUiGw@mail.gmail.com>
On Thu, 14 May 2020, Huacai Chen wrote:
> > Sigh, this just shows how the original change was wrong in the first
> > place. Why was <asm/inst.h> specifically chosen, whose purpose has been
> > machine code generators/interpreters that has nothing to do with unaligned
> > access helpers, over a more suitable location, such as (maybe obviously?)
> > <asm/unaligned.h>?
> >
> > I suggest that we roll back to before the destruction, move the necessary
> > bits away from <asm/inst.h>, and then perhaps none of the follow-up hacks
> > will be required.
> I think you are right, but it is too late... so, I think we needn't roll back.
Well, your change hasn't even hit the mainline yet, and anyway it's never
too late to get things right (it's not like software gets cast in stone)
and as I say these bits do not functionally belong to <asm/inst.h>.
Maciej
prev parent reply other threads:[~2020-05-14 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 9:30 [PATCH] MIPS: inst.h: Stop including asm.h to avoid various build failures Huacai Chen
2020-05-08 13:01 ` Thomas Bogendoerfer
2020-05-09 4:10 ` Huacai Chen
2020-05-09 15:25 ` Thomas Bogendoerfer
2020-05-12 23:52 ` Maciej W. Rozycki
2020-05-14 5:46 ` Huacai Chen
2020-05-14 12:23 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2005141316390.6492@redsun52.ssa.fujisawa.hgst.com \
--to=macro@wdc.com \
--cc=chenhc@lemote.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-mips@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.