From: Julian Anastasov <ja@ssi.bg>
To: Lach <iam@lach.pw>
Cc: Wensong Zhang <wensong@linux-vs.org>,
Simon Horman <horms@verge.net.au>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove ipvs v6 dependency on iptables
Date: Thu, 27 Aug 2020 23:59:24 +0300 (EEST) [thread overview]
Message-ID: <alpine.LFD.2.23.451.2008272357240.4567@ja.home.ssi.bg> (raw)
In-Reply-To: <20200827194802.1164-1-iam@lach.pw>
Hello,
On Fri, 28 Aug 2020, Lach wrote:
> This dependency was added in 63dca2c0b0e7a92cb39d1b1ecefa32ffda201975, because this commit had dependency on
> ipv6_find_hdr, which was located in iptables-specific code
>
> But it is no longer required, because f8f626754ebeca613cf1af2e6f890cfde0e74d5b moved them to a more common location
May be then we should also not include ip6_tables.h from
include/net/ip_vs.h ?
> ---
> net/netfilter/ipvs/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/netfilter/ipvs/Kconfig b/net/netfilter/ipvs/Kconfig
> index 2c1593089..eb0e329f9 100644
> --- a/net/netfilter/ipvs/Kconfig
> +++ b/net/netfilter/ipvs/Kconfig
> @@ -29,7 +29,6 @@ if IP_VS
> config IP_VS_IPV6
> bool "IPv6 support for IPVS"
> depends on IPV6 = y || IP_VS = IPV6
> - select IP6_NF_IPTABLES
> select NF_DEFRAG_IPV6
> help
> Add IPv6 support to IPVS.
> --
> 2.28.0
Regards
--
Julian Anastasov <ja@ssi.bg>
next prev parent reply other threads:[~2020-08-27 21:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 19:48 [PATCH] Remove ipvs v6 dependency on iptables Lach
2020-08-27 19:48 ` Lach
2020-08-27 20:59 ` Julian Anastasov [this message]
2020-08-27 22:07 ` Lach
2020-08-28 15:08 ` Nicolas Dichtel
2020-08-29 8:50 ` Yaroslav Bolyukin
2020-08-29 9:58 ` Julian Anastasov
2020-08-29 9:58 ` Julian Anastasov
2020-08-29 10:51 ` [PATCHv4 net-next] " Yaroslav Bolyukin
2020-08-29 13:59 ` [PATCHv5 net-next] ipvs: remove dependency on ip6_tables Yaroslav Bolyukin
2020-08-31 17:12 ` Julian Anastasov
2020-08-31 17:12 ` Julian Anastasov
2020-08-31 21:18 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.23.451.2008272357240.4567@ja.home.ssi.bg \
--to=ja@ssi.bg \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=iam@lach.pw \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.