From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Subject: Re: [patch]cleanup of hiddev Date: Mon, 15 Dec 2008 17:01:07 +0100 (CET) Message-ID: References: <200812091319.59054.oliver@neukum.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <200812091319.59054.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Oliver Neukum Cc: Jiri Slaby , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, USB list , Dmitry Torokhov List-Id: linux-input@vger.kernel.org On Tue, 9 Dec 2008, Oliver Neukum wrote: > commit f05614115c77fae393b3a262780f8f13ff485173 > Author: Oliver Neukum > Date: Tue Dec 9 13:09:56 2008 +0100 > > cleanup of hiddev > > - thread safety > - fix race between ioctl and disconnect > - race in open > - error checking > - O_NONBLOCK handled Hi Oliver, I have finally gone through the patch, and I think it is OK. I'd prefer taking the individual cleanups as individual patches though, if you have it split in your tree. Or at least more descriptive changelog, explaining the bugs fixed in deeper detail, would be nice to have. Thanks! -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html