From: Jiri Kosina <email@example.com>
To: Jeff Smith <firstname.lastname@example.org>
Cc: email@example.com, Vegard Nossum <firstname.lastname@example.org>
Subject: Re: [kmemcheck] WARNING: kmemcheck: Caught 32-bit read from uninitialized memory, in hid_output_report
Date: Fri, 4 Sep 2009 15:04:03 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.email@example.com> (raw)
On Sun, 30 Aug 2009, Jeff Smith wrote:
> A patch follows. It corrects a typo in the comment, changes the function
> name "implement" to "set_into_le_bitstream", changes the parameter name
> "n" to "bitfield_size", printk's unsigned using %u not %d, and only does
> a 32-bit read-modify-write when a 64-bit one is not necessary.
> A patch that writes only the bytes that need to be changed, rather than
> 32 or 64-bit quantities that potentially access irrelevant memory
> locations -- and that therefore require more complicated verification
> logic -- would be a better approach. However, as we are at -rc8 already
> and I don't fully understand the structures that are being changed, or
> the reasons the code is as it is, I didn't feel confident about
> presenting such a restructuring here.
thanks for the patch, it looks correct on a quick glance. I would however
prefer the other approach you proposed.
We probably don't have to be nervous about being currently at -rc8, as
this will probably be fixed only in .32-rc1 anyway (as the unitialized
data is not used in any way, and therefore it doesn't require emergency
fix just to silence the kmemcheck warning).
prev parent reply other threads:[~2009-09-04 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 19:45 [kmemcheck] WARNING: kmemcheck: Caught 32-bit read from uninitialized memory, in hid_output_report Jeff Smith
2009-08-30 21:38 ` Jeff Smith
2009-09-04 13:04 ` Jiri Kosina [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.