From: Jiri Kosina <jkosina@suse.cz>
To: Oliver Neukum <oliver@neukum.org>
Cc: Henk Martijn <h.h.martijn@gmail.com>,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
Greg KH <gregkh@suse.de>
Subject: Re: [patch]fix usbhid using GFP_KERNEL in interrupt
Date: Mon, 21 Sep 2009 23:42:47 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.0909212340020.17028@wotan.suse.de> (raw)
In-Reply-To: <200909212237.19281.oliver@neukum.org>
On Mon, 21 Sep 2009, Oliver Neukum wrote:
> > > hid:usbhid: fix wrong use of GFP_KERNEL
> > >
> > > hid_input_report() must be told it is called in interrupt context
> > >
> > > Signed-off-by: Oliver Neukum <oliver@neukum.org>
> > >
> > > Hi Jiri, Greg,
> > >
> > > this should go into the current tree and the stable tree.
> >
> > Stable? Interestingly I did not have any problems with 2.6.31......
>
> OK, Greg, hold your fire. Jiri is this necessary in stable?
Hi,
no, it's not. 2.6.31 doesn't do any allocation in hid_input_report(), this
is new with HID debugging through debugfs that went to Linus in 2.6.32
merge window.
The fix for this particular problem is already on its way upstream,
waiting for Linus to pull.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
prev parent reply other threads:[~2009-09-21 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 20:25 [patch]fix usbhid using GFP_KERNEL in interrupt Oliver Neukum
2009-09-21 20:33 ` Henk Martijn
2009-09-21 20:37 ` Oliver Neukum
2009-09-21 21:42 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.0909212340020.17028@wotan.suse.de \
--to=jkosina@suse.cz \
--cc=gregkh@suse.de \
--cc=h.h.martijn@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.