From: Jaroslav Kysela <perex@perex.cz>
To: John Sauter <John_Sauter@systemeyescomputerstore.com>
Cc: devel@alsa-project.org
Subject: Re: audio surveilance
Date: Fri, 8 Jan 2010 15:58:36 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1001081546130.4210@eeebox2.perex-int.cz> (raw)
In-Reply-To: <1262889015.28819.6.camel@sauterws02.sauterhome>
On Thu, 7 Jan 2010, John Sauter wrote:
> Mr. Kysela,
>
> I have some patches to aplay to make it more useful for audio
> surveillance. I have submitted the patches to the devel mailing list
> for comment here:
> <http://mailman.alsa-project.org/pipermail/alsa-devel/2010-January/024278.html>.
>
> I have received no negative comments, so I would like to propose these
> patches for inclusion in mainline. What is the procedure for submitting
> patches for alsa-util?
Could you, please, a bit clean up your patch?
- There are a lot of "if (pidfile_written) remove (pidfile_name)" lines.
It would be better to create another function like prg_exit() and add
this code there.
- Many C expressions are not splitted to more lines:
"if (max_file_size && (rest > max_file_size)) rest = max_file_size;"
- Check all conditions. Use && and || operators instead bit-like AND (&)
and OR (|). Like "if (filecount | use_strftime) {" etc.
- I would also appreciate, if you can split '--process-id-file' code
changes and rest of implementation to two standalone patches for more
easier review. Also, your patch contains some "space/tab replacements" -
it might be moved to another patch too.
Thanks,
Jaroslav
-----
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.
next prev parent reply other threads:[~2010-01-08 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 3:54 [RFC] audio surveilance John Sauter
2010-01-07 18:30 ` John Sauter
2010-01-08 14:58 ` Jaroslav Kysela [this message]
2010-01-08 18:45 ` John Sauter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1001081546130.4210@eeebox2.perex-int.cz \
--to=perex@perex.cz \
--cc=John_Sauter@systemeyescomputerstore.com \
--cc=devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.