From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753737Ab0CZU7Y (ORCPT ); Fri, 26 Mar 2010 16:59:24 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34558 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753378Ab0CZU7W (ORCPT ); Fri, 26 Mar 2010 16:59:22 -0400 Date: Fri, 26 Mar 2010 21:59:19 +0100 (CET) From: Jiri Kosina To: =?ISO-8859-15?Q?Bruno_Pr=E9mont?= Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." , Nicu Pavel , Oliver Neukum , Jaya Kumar Subject: Re: [PATCH v3 1/6] hid: new driver for PicoLCD device In-Reply-To: <20100326102951.3b9ecda1@neptune.home> Message-ID: References: <20100324233707.7243b04d@neptune.home> <20100324234022.0361bd80@neptune.home> <20100326065656.GC26602@core.coreip.homeip.net> <20100326102951.3b9ecda1@neptune.home> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Mar 2010, Bruno Prémont wrote: > > > + for (i = 0; i < PICOLCD_KEYS; i++) { > > > + int key = ((int *)idev->keycode)[i]; > > > > Keycodes are now short, not int. Also, just do: > > > > input_set_capability(idev, EV_KEY, data->keycode[i]); > > > > > + if (key < KEY_MAX && key >= 0) > > > + input_set_capability(idev, EV_KEY, key); > > Oops, I was not careful enough when switching over... Dmitry, thanks a lot for rapid review the driver. Bruno, could you please fix this and submit a followup 1/6 patch, so that I could queue the driver in my tree? I have almost finished going over the driver and haven't encountered any other issues that would require immediate fixing. Still, it would be nice to have the framebuffer/LCD/backlight bits reviewed by respective subsystem maintainers. But I'll probably queue the driver nevertheless and add potential ACKs later. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Subject: Re: [PATCH v3 1/6] hid: new driver for PicoLCD device Date: Fri, 26 Mar 2010 21:59:19 +0100 (CET) Message-ID: References: <20100324233707.7243b04d@neptune.home> <20100324234022.0361bd80@neptune.home> <20100326065656.GC26602@core.coreip.homeip.net> <20100326102951.3b9ecda1@neptune.home> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from cantor2.suse.de ([195.135.220.15]:34558 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753378Ab0CZU7W (ORCPT ); Fri, 26 Mar 2010 16:59:22 -0400 In-Reply-To: <20100326102951.3b9ecda1@neptune.home> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: =?ISO-8859-15?Q?Bruno_Pr=E9mont?= Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." , Nicu Pavel , Oliver Neukum , Jaya Kumar On Fri, 26 Mar 2010, Bruno Pr=E9mont wrote: > > > + for (i =3D 0; i < PICOLCD_KEYS; i++) { > > > + int key =3D ((int *)idev->keycode)[i]; > >=20 > > Keycodes are now short, not int. Also, just do: > >=20 > > input_set_capability(idev, EV_KEY, data->keycode[i]); > >=20 > > > + if (key < KEY_MAX && key >=3D 0) > > > + input_set_capability(idev, EV_KEY, key); >=20 > Oops, I was not careful enough when switching over... Dmitry, thanks a lot for rapid review the driver. Bruno, could you please fix this and submit a followup 1/6 patch, so th= at=20 I could queue the driver in my tree? I have almost finished going over the driver and haven't encountered an= y=20 other issues that would require immediate fixing. Still, it would be nice to have the framebuffer/LCD/backlight bits=20 reviewed by respective subsystem maintainers. But I'll probably queue t= he=20 driver nevertheless and add potential ACKs later. Thanks, --=20 Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Date: Fri, 26 Mar 2010 20:59:19 +0000 Subject: Re: [PATCH v3 1/6] hid: new driver for PicoLCD device Message-Id: List-Id: References: <20100324233707.7243b04d@neptune.home> <20100324234022.0361bd80@neptune.home> <20100326065656.GC26602@core.coreip.homeip.net> <20100326102951.3b9ecda1@neptune.home> In-Reply-To: <20100326102951.3b9ecda1@neptune.home> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: =?ISO-8859-15?Q?Bruno_Pr=E9mont?= Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." , Nicu Pavel , Oliver Neukum , Jaya Kumar On Fri, 26 Mar 2010, Bruno Pr=E9mont wrote: > > > + for (i =3D 0; i < PICOLCD_KEYS; i++) { > > > + int key =3D ((int *)idev->keycode)[i]; > >=20 > > Keycodes are now short, not int. Also, just do: > >=20 > > input_set_capability(idev, EV_KEY, data->keycode[i]); > >=20 > > > + if (key < KEY_MAX && key >=3D 0) > > > + input_set_capability(idev, EV_KEY, key); >=20 > Oops, I was not careful enough when switching over... Dmitry, thanks a lot for rapid review the driver. Bruno, could you please fix this and submit a followup 1/6 patch, so that=20 I could queue the driver in my tree? I have almost finished going over the driver and haven't encountered any=20 other issues that would require immediate fixing. Still, it would be nice to have the framebuffer/LCD/backlight bits=20 reviewed by respective subsystem maintainers. But I'll probably queue the=20 driver nevertheless and add potential ACKs later. Thanks, --=20 Jiri Kosina SUSE Labs, Novell Inc.