All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>
To: Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RESEND] USB HID: Protect against disconnect/NULL-dereference race
Date: Fri, 13 Aug 2010 11:21:50 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.00.1008131121370.2702@pobox.suse.cz> (raw)
In-Reply-To: <m3lj8b8m6b.fsf-0VGQAjvlmrQzNDMTQreKSUB+6BGkLq7r@public.gmane.org>

On Thu, 12 Aug 2010, Chris Ball wrote:

> One of our users reports consistently hitting a NULL dereference that
> resolves to the "hid_to_usb_dev(hid);" call in hiddev_ioctl(), when
> disconnecting a Lego WeDo USB HID device from an OLPC XO running
> Scratch software.  There's a FIXME comment and a guard against the
> dereference, but that happens farther down the function than the
> initial dereference does.
> 
> This patch moves the call to be below the guard, and the user reports
> that it fixes the problem for him.  OLPC bug report:
> http://dev.laptop.org/ticket/10174
> 
> Signed-off-by: Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>

Applied, thanks Chris.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2010-08-13  9:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m3y6ee62gp.fsf@pullcord.laptop.org>
2010-08-12 23:07 ` Chris Ball
     [not found]   ` <m3lj8b8m6b.fsf-0VGQAjvlmrQzNDMTQreKSUB+6BGkLq7r@public.gmane.org>
2010-08-13  8:55     ` Amit Nagal
2010-08-13  9:21     ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1008131121370.2702@pobox.suse.cz \
    --to=jkosina-alswssmvlrq@public.gmane.org \
    --cc=cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
    --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --subject='Re: [PATCH RESEND] USB HID: Protect against disconnect/NULL-dereference race' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.