All of
 help / color / mirror / Atom feed
From: Jiri Kosina <>
To: Chris Ball <>
Subject: Re: [PATCH RESEND] USB HID: Protect against disconnect/NULL-dereference race
Date: Fri, 13 Aug 2010 11:21:50 +0200 (CEST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, 12 Aug 2010, Chris Ball wrote:

> One of our users reports consistently hitting a NULL dereference that
> resolves to the "hid_to_usb_dev(hid);" call in hiddev_ioctl(), when
> disconnecting a Lego WeDo USB HID device from an OLPC XO running
> Scratch software.  There's a FIXME comment and a guard against the
> dereference, but that happens farther down the function than the
> initial dereference does.
> This patch moves the call to be below the guard, and the user reports
> that it fixes the problem for him.  OLPC bug report:
> Signed-off-by: Chris Ball <>

Applied, thanks Chris.

Jiri Kosina
SUSE Labs, Novell Inc.
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to
More majordomo info at

      parent reply	other threads:[~2010-08-13  9:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2010-08-12 23:07 ` Chris Ball
     [not found]   ` <>
2010-08-13  8:55     ` Amit Nagal
2010-08-13  9:21     ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH RESEND] USB HID: Protect against disconnect/NULL-dereference race' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.