From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Subject: Re: [PATCH 02/13] drivers/infiniband: Remove unnecessary casts of private_data Date: Thu, 23 Sep 2010 13:38:46 +0200 (CEST) Message-ID: References: <1283883869.32259.13.camel@chromite.mv.qlogic.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <1283883869.32259.13.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ralph Campbell Cc: Joe Perches , Roland Dreier , Sean Hefty , Hal Rosenstock , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Tue, 7 Sep 2010, Ralph Campbell wrote: > Acked-by: Ralph Campbell Applied, thanks. > > Signed-off-by: Joe Perches > > --- > > drivers/infiniband/hw/qib/qib_file_ops.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/infiniband/hw/qib/qib_file_ops.c b/drivers/infiniband/hw/qib/qib_file_ops.c > > index 6b11645..cef5d67 100644 > > --- a/drivers/infiniband/hw/qib/qib_file_ops.c > > +++ b/drivers/infiniband/hw/qib/qib_file_ops.c > > @@ -1722,7 +1722,7 @@ static int qib_close(struct inode *in, struct file *fp) > > > > mutex_lock(&qib_mutex); > > > > - fd = (struct qib_filedata *) fp->private_data; > > + fd = fp->private_data; > > fp->private_data = NULL; > > rcd = fd->rcd; > > if (!rcd) { > > @@ -1808,7 +1808,7 @@ static int qib_ctxt_info(struct file *fp, struct qib_ctxt_info __user *uinfo) > > struct qib_ctxtdata *rcd = ctxt_fp(fp); > > struct qib_filedata *fd; > > > > - fd = (struct qib_filedata *) fp->private_data; > > + fd = fp->private_data; > > > > info.num_active = qib_count_active_units(); > > info.unit = rcd->dd->unit; -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754731Ab0IWLiv (ORCPT ); Thu, 23 Sep 2010 07:38:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54375 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845Ab0IWLit (ORCPT ); Thu, 23 Sep 2010 07:38:49 -0400 Date: Thu, 23 Sep 2010 13:38:46 +0200 (CEST) From: Jiri Kosina To: Ralph Campbell Cc: Joe Perches , Roland Dreier , Sean Hefty , Hal Rosenstock , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 02/13] drivers/infiniband: Remove unnecessary casts of private_data In-Reply-To: <1283883869.32259.13.camel@chromite.mv.qlogic.com> Message-ID: References: <1283883869.32259.13.camel@chromite.mv.qlogic.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Sep 2010, Ralph Campbell wrote: > Acked-by: Ralph Campbell Applied, thanks. > > Signed-off-by: Joe Perches > > --- > > drivers/infiniband/hw/qib/qib_file_ops.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/infiniband/hw/qib/qib_file_ops.c b/drivers/infiniband/hw/qib/qib_file_ops.c > > index 6b11645..cef5d67 100644 > > --- a/drivers/infiniband/hw/qib/qib_file_ops.c > > +++ b/drivers/infiniband/hw/qib/qib_file_ops.c > > @@ -1722,7 +1722,7 @@ static int qib_close(struct inode *in, struct file *fp) > > > > mutex_lock(&qib_mutex); > > > > - fd = (struct qib_filedata *) fp->private_data; > > + fd = fp->private_data; > > fp->private_data = NULL; > > rcd = fd->rcd; > > if (!rcd) { > > @@ -1808,7 +1808,7 @@ static int qib_ctxt_info(struct file *fp, struct qib_ctxt_info __user *uinfo) > > struct qib_ctxtdata *rcd = ctxt_fp(fp); > > struct qib_filedata *fd; > > > > - fd = (struct qib_filedata *) fp->private_data; > > + fd = fp->private_data; > > > > info.num_active = qib_count_active_units(); > > info.unit = rcd->dd->unit; -- Jiri Kosina SUSE Labs, Novell Inc.