From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754880Ab0IWLpU (ORCPT ); Thu, 23 Sep 2010 07:45:20 -0400 Received: from cantor.suse.de ([195.135.220.2]:54119 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497Ab0IWLpS (ORCPT ); Thu, 23 Sep 2010 07:45:18 -0400 Date: Thu, 23 Sep 2010 13:45:13 +0200 (CEST) From: Jiri Kosina To: Joe Perches Cc: Adaptec OEM Raid Solutions , "James E.J. Bottomley" , Doug Gilbert , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/13] drivers/scsi: Remove unnecessary casts of private_data In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 4 Sep 2010, Joe Perches wrote: > Signed-off-by: Joe Perches > --- > drivers/scsi/aacraid/linit.c | 2 +- > drivers/scsi/sg.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c > index cad6f9a..aa40036 100644 > --- a/drivers/scsi/aacraid/linit.c > +++ b/drivers/scsi/aacraid/linit.c > @@ -770,7 +770,7 @@ static long aac_compat_cfg_ioctl(struct file *file, unsigned cmd, unsigned long > { > if (!capable(CAP_SYS_RAWIO)) > return -EPERM; > - return aac_compat_do_ioctl((struct aac_dev *)file->private_data, cmd, arg); > + return aac_compat_do_ioctl(file->private_data, cmd, arg); > } > #endif > > diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c > index 78d6163..6efa8dd 100644 > --- a/drivers/scsi/sg.c > +++ b/drivers/scsi/sg.c > @@ -210,7 +210,7 @@ static void sg_put_dev(Sg_device *sdp); > > static int sg_allow_access(struct file *filp, unsigned char *cmd) > { > - struct sg_fd *sfp = (struct sg_fd *)filp->private_data; > + struct sg_fd *sfp = filp->private_data; > > if (sfp->parentdp->device->type == TYPE_SCANNER) > return 0; This patch isn't present in linux-next as of today. Applying to my tree now. -- Jiri Kosina SUSE Labs, Novell Inc.