From: Jiri Kosina <jkosina@suse.cz>
To: Chase Douglas <chase.douglas@canonical.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Philipp Merkel <mail@philmerk.de>,
Stephane Chatty <chatty@enac.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] hid: egalax: Use kzalloc
Date: Thu, 4 Nov 2010 10:41:10 -0400 (EDT) [thread overview]
Message-ID: <alpine.LNX.2.00.1011041041010.15851@pobox.suse.cz> (raw)
In-Reply-To: <1286991373.31864.193.camel@mini>
On Wed, 13 Oct 2010, Chase Douglas wrote:
> > To avoid unnecessary explicit initialization, allocate zeroed memory.
> >
> > Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
> > ---
> > drivers/hid/hid-egalax.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/hid/hid-egalax.c b/drivers/hid/hid-egalax.c
> > index 54b017a..5a1b52e 100644
> > --- a/drivers/hid/hid-egalax.c
> > +++ b/drivers/hid/hid-egalax.c
> > @@ -221,7 +221,7 @@ static int egalax_probe(struct hid_device *hdev, const struct hid_device_id *id)
> > struct egalax_data *td;
> > struct hid_report *report;
> >
> > - td = kmalloc(sizeof(struct egalax_data), GFP_KERNEL);
> > + td = kzalloc(sizeof(struct egalax_data), GFP_KERNEL);
> > if (!td) {
> > dev_err(&hdev->dev, "cannot allocate eGalax data\n");
> > return -ENOMEM;
>
> Pretty obvious.
>
> Acked-by: Chase Douglas <chase.douglas@canonical.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2010-11-04 14:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 13:58 [PATCH 0/6] hid: egalax: Rework to include joojoo support Henrik Rydberg
2010-10-13 13:58 ` [PATCH 1/6] hid: egalax: Use kzalloc Henrik Rydberg
2010-10-13 17:36 ` Chase Douglas
2010-11-04 14:41 ` Jiri Kosina [this message]
2010-10-13 13:58 ` [PATCH 2/6] hid: egalax: Setup input device manually Henrik Rydberg
2010-10-13 17:43 ` Chase Douglas
2010-10-13 13:58 ` [PATCH 3/6] hid: egalax: Correct for device resolution report error Henrik Rydberg
2010-10-13 17:43 ` Chase Douglas
2010-10-13 20:13 ` Henrik Rydberg
2010-10-13 20:29 ` [PATCH 3/6] hid: egalax: Correct for device resolution report error (rev2) Henrik Rydberg
2010-10-13 20:30 ` [PATCH 5/6] hid: egalax: Add event filtering (rev2) Henrik Rydberg
2010-10-13 13:58 ` [PATCH 4/6] hid: egalax: Report zero as minimum pressure Henrik Rydberg
2010-10-13 17:54 ` Chase Douglas
2010-10-13 13:58 ` [PATCH 5/6] hid: egalax: Add event filtering Henrik Rydberg
2010-10-13 17:55 ` Chase Douglas
2010-10-13 13:58 ` [PATCH 6/6] hid: egalax: Convert to MT slots Henrik Rydberg
2010-10-13 17:35 ` Chase Douglas
2010-10-15 14:37 ` [PATCH 0/6] hid: egalax: Rework to include joojoo support Jiri Kosina
2010-11-04 14:43 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1011041041010.15851@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=chase.douglas@canonical.com \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@philmerk.de \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.