From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpNaU-0001gg-IZ for qemu-devel@nongnu.org; Fri, 05 Aug 2011 12:49:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QpNaT-0001nR-6J for qemu-devel@nongnu.org; Fri, 05 Aug 2011 12:49:30 -0400 Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:56862 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QpNaS-0001n0-RB for qemu-devel@nongnu.org; Fri, 05 Aug 2011 12:49:29 -0400 Date: Fri, 5 Aug 2011 20:49:15 +0400 (MSD) From: malc In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="33734824-170188933-1312562956=:2145" Subject: Re: [Qemu-devel] Build broken List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, qemu-devel@nongnu.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --33734824-170188933-1312562956=:2145 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT On Fri, 5 Aug 2011, Stefan Hajnoczi wrote: > On Fri, Aug 5, 2011 at 7:22 AM, malc wrote: > > > > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function 'coroutine_new': > > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error: 'arg.i[1]' may be used uninitialized in this function > > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:136:18: note: 'arg.i[1]' was declared here > > > > diff --git a/coroutine-ucontext.c b/coroutine-ucontext.c > > index 41c2379..42dc3e2 100644 > > --- a/coroutine-ucontext.c > > +++ b/coroutine-ucontext.c > > @@ -133,7 +133,7 @@ static Coroutine *coroutine_new(void) > >     CoroutineUContext *co; > >     ucontext_t old_uc, uc; > >     jmp_buf old_env; > > -    union cc_arg arg; > > +    union cc_arg arg = {0}; > > > >     /* The ucontext functions preserve signal masks which incurs a system call > >      * overhead.  setjmp()/longjmp() does not preserve signal masks but only > > > > I guess gcc should yell not only here on ppc32 but on any machine where > > pointer size is less than the size of two ints. > > Makes sense. Are you going to commit a fix or send a signed-off-by patch? > If the author(s)(you and Kevin? just you?) agree with the above i can just push it. -- mailto:av1474@comtv.ru --33734824-170188933-1312562956=:2145--