From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QynaL-0002lD-C4 for qemu-devel@nongnu.org; Wed, 31 Aug 2011 12:24:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QynaK-0002px-C0 for qemu-devel@nongnu.org; Wed, 31 Aug 2011 12:24:17 -0400 Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:50782 helo=akado.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QynaK-0002pt-5V for qemu-devel@nongnu.org; Wed, 31 Aug 2011 12:24:16 -0400 Date: Wed, 31 Aug 2011 20:24:09 +0400 (MSD) From: malc In-Reply-To: <4E5E5BF3.50801@codemonkey.ws> Message-ID: References: <1314752751.84463.YahooMailClassic@web27003.mail.ukl.yahoo.com> <4E5D8BAA.9010302@codemonkey.ws> <4E5D9570.1030201@codemonkey.ws> <4E5E3789.3010603@codemonkey.ws> <4E5E39DF.3080609@codemonkey.ws> <4E5E4540.5030408@codemonkey.ws> <4E5E5BF3.50801@codemonkey.ws> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, bifferos On Wed, 31 Aug 2011, Anthony Liguori wrote: > On 08/31/2011 09:35 AM, malc wrote: > > On Wed, 31 Aug 2011, Anthony Liguori wrote: > > > > > Upper case field names are not okay. If you think coding style isn't > > > clear, > > > that's a bug in coding style. > > > > Sez hu? Coding style is garbage that should be thrown out of the window. > > As for looking, yeah, i'm looking at usb with it's lovely hungarian > > fields, should we stampede to "fix" it? > > > > If the one who's going to maintain the code is fine with whatever naming > > is used so be it. > > No. That's how we got into the coding style mess we're in in the first > place. boblycat.org/~malc/right.ogg > > There's no benefit to going through and changing existing code but new code > needs to be consistent with the vast majority of code in the rest of the tree. > It's about overall code base consistency and maintainability. > Hand waving, for instance vast majority of the code never used the mandatory braces, the choice was arbitrary. -- mailto:av1474@comtv.ru