All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Aureal Remote Control Device Driver
@ 2012-03-30 21:08 Josenivaldo Benito Junior
  2012-04-09  0:08 ` Jiri Kosina
  0 siblings, 1 reply; 8+ messages in thread
From: Josenivaldo Benito Junior @ 2012-03-30 21:08 UTC (permalink / raw)
  To: Jiri Kosina, linux-input, linux-kernel
  Cc: Josenivaldo Benito Junior, Franco Catrin

From: "Josenivaldo Benito Junior" <jrbenito@benito.qsl.br>

Devices like Aureal Cy se W-01RN USB_V3.1 and some derived hardware
have a bogus HID Report Descriptor. According to that report descriptor,
the maximum logical value for key events is 1 and not 101 (101 keys).

This quirk fixes this wrong Report Descriptor and is basically the same found
in hid-elecom.c.

Original driver can be found at: https://gitorious.org/hid-aureal-kernel-module

Signed-off-by: Josenivaldo Benito Junior <jrbenito@benito.qsl.br>
Signed-off-by: Franco Catrin <fcatrin@gmail.com>
---
 drivers/hid/Kconfig      |    6 +++++
 drivers/hid/Makefile     |    1 +
 drivers/hid/hid-aureal.c |   54 ++++++++++++++++++++++++++++++++++++++++++++++
 drivers/hid/hid-ids.h    |    3 ++
 4 files changed, 64 insertions(+), 0 deletions(-)
 create mode 100644 drivers/hid/hid-aureal.c

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 4ecc256..03e2281 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -92,6 +92,12 @@ config HID_APPLE
 	Say Y here if you want support for keyboards of	Apple iBooks, PowerBooks,
 	MacBooks, MacBook Pros and Apple Aluminum.
 
+config HID_AUREAL
+	tristate "Aureal"
+	depends on USB_HID
+	---help---
+	Support for Aureal Cy se W-01RN Remote Controller and other Aureal derived remotes.
+
 config HID_BELKIN
 	tristate "Belkin Flip KVM and Wireless keyboard" if EXPERT
 	depends on USB_HID
diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
index 22f1d16..5363f17 100644
--- a/drivers/hid/Makefile
+++ b/drivers/hid/Makefile
@@ -36,6 +36,7 @@ endif
 obj-$(CONFIG_HID_A4TECH)	+= hid-a4tech.o
 obj-$(CONFIG_HID_ACRUX)		+= hid-axff.o
 obj-$(CONFIG_HID_APPLE)		+= hid-apple.o
+obj-$(CONFIG_HID_AUREAL)        += hid-aureal.o
 obj-$(CONFIG_HID_BELKIN)	+= hid-belkin.o
 obj-$(CONFIG_HID_CHERRY)	+= hid-cherry.o
 obj-$(CONFIG_HID_CHICONY)	+= hid-chicony.o
diff --git a/drivers/hid/hid-aureal.c b/drivers/hid/hid-aureal.c
new file mode 100644
index 0000000..9fb676b
--- /dev/null
+++ b/drivers/hid/hid-aureal.c
@@ -0,0 +1,54 @@
+/*
+ *  HID driver for Aureal Cy se W-01RN USB_V3.1 devices
+ *
+ *  Copyright (c) 2010 Franco Catrin <fcatrin@gmail.com>
+ *  Copyright (c) 2010 Ben Cropley <bcropley@internode.on.net>
+ *
+ *  Based on HID sunplus driver by
+ *  Copyright (c) 1999 Andreas Gal
+ *  Copyright (c) 2000-2005 Vojtech Pavlik <vojtech@suse.cz>
+ *  Copyright (c) 2005 Michael Haboustak <mike-@cinci.rr.com> for Concept2, Inc
+ *  Copyright (c) 2006-2007 Jiri Kosina
+ *  Copyright (c) 2007 Paul Walmsley
+ *  Copyright (c) 2008 Jiri Slaby
+ */
+#include <linux/device.h>
+#include <linux/hid.h>
+#include <linux/module.h>
+
+#include "hid-ids.h"
+
+static __u8 *aureal_report_fixup(struct hid_device *hdev, __u8 *rdesc,
+		unsigned int *rsize)
+{
+	if (*rsize >= 54 && rdesc[52] == 0x25 && rdesc[53] == 0x01) {
+		dev_info(&hdev->dev, "fixing Aureal Cy se W-01RN USB_V3.1 report descriptor. Keyboard Logical Maximum = 101\n");
+		rdesc[53] = 0x65;
+	} return rdesc;
+}
+
+static const struct hid_device_id aureal_devices[] = {
+	{ HID_USB_DEVICE(USB_VENDOR_ID_AUREAL, USB_DEVICE_ID_AUREAL_W01RN) },
+	{ }
+};
+MODULE_DEVICE_TABLE(hid, aureal_devices);
+
+static struct hid_driver aureal_driver = {
+	.name = "aureal",
+	.id_table = aureal_devices,
+	.report_fixup = aureal_report_fixup,
+};
+
+static int __init aureal_init(void)
+{
+	return hid_register_driver(&aureal_driver);
+}
+
+static void __exit aureal_exit(void)
+{
+	hid_unregister_driver(&aureal_driver);
+}
+
+module_init(aureal_init);
+module_exit(aureal_exit);
+MODULE_LICENSE("GPL");
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 2b67e84..720c9e7 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -154,6 +154,9 @@
 #define USB_DEVICE_ID_ATMEL_MULTITOUCH	0x211c
 #define USB_DEVICE_ID_ATMEL_MXT_DIGITIZER	0x2118
 
+#define USB_VENDOR_ID_AUREAL		0x0755
+#define USB_DEVICE_ID_AUREAL_W01RN	0x2626
+
 #define USB_VENDOR_ID_AVERMEDIA		0x07ca
 #define USB_DEVICE_ID_AVER_FM_MR800	0xb800
 
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] Aureal Remote Control Device Driver
  2012-03-30 21:08 [PATCH] Aureal Remote Control Device Driver Josenivaldo Benito Junior
@ 2012-04-09  0:08 ` Jiri Kosina
  2012-04-10 22:29   ` [PATCH 0/3] RESEND Aureal special HID driver Josenivaldo Benito Junior
                     ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Jiri Kosina @ 2012-04-09  0:08 UTC (permalink / raw)
  To: Josenivaldo Benito Junior; +Cc: linux-input, linux-kernel, Franco Catrin

On Fri, 30 Mar 2012, Josenivaldo Benito Junior wrote:

> From: "Josenivaldo Benito Junior" <jrbenito@benito.qsl.br>
> 
> Devices like Aureal Cy se W-01RN USB_V3.1 and some derived hardware
> have a bogus HID Report Descriptor. According to that report descriptor,
> the maximum logical value for key events is 1 and not 101 (101 keys).
> 
> This quirk fixes this wrong Report Descriptor and is basically the same found
> in hid-elecom.c.
> 
> Original driver can be found at: https://gitorious.org/hid-aureal-kernel-module
> 
> Signed-off-by: Josenivaldo Benito Junior <jrbenito@benito.qsl.br>
> Signed-off-by: Franco Catrin <fcatrin@gmail.com>
> ---
>  drivers/hid/Kconfig      |    6 +++++
>  drivers/hid/Makefile     |    1 +
>  drivers/hid/hid-aureal.c |   54 ++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/hid/hid-ids.h    |    3 ++
>  4 files changed, 64 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/hid/hid-aureal.c
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 4ecc256..03e2281 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -92,6 +92,12 @@ config HID_APPLE
>  	Say Y here if you want support for keyboards of	Apple iBooks, PowerBooks,
>  	MacBooks, MacBook Pros and Apple Aluminum.
>  
> +config HID_AUREAL
> +	tristate "Aureal"
> +	depends on USB_HID
> +	---help---
> +	Support for Aureal Cy se W-01RN Remote Controller and other Aureal derived remotes.
> +
>  config HID_BELKIN
>  	tristate "Belkin Flip KVM and Wireless keyboard" if EXPERT
>  	depends on USB_HID
> diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
> index 22f1d16..5363f17 100644
> --- a/drivers/hid/Makefile
> +++ b/drivers/hid/Makefile
> @@ -36,6 +36,7 @@ endif
>  obj-$(CONFIG_HID_A4TECH)	+= hid-a4tech.o
>  obj-$(CONFIG_HID_ACRUX)		+= hid-axff.o
>  obj-$(CONFIG_HID_APPLE)		+= hid-apple.o
> +obj-$(CONFIG_HID_AUREAL)        += hid-aureal.o
>  obj-$(CONFIG_HID_BELKIN)	+= hid-belkin.o
>  obj-$(CONFIG_HID_CHERRY)	+= hid-cherry.o
>  obj-$(CONFIG_HID_CHICONY)	+= hid-chicony.o
> diff --git a/drivers/hid/hid-aureal.c b/drivers/hid/hid-aureal.c
> new file mode 100644
> index 0000000..9fb676b
> --- /dev/null
> +++ b/drivers/hid/hid-aureal.c
> @@ -0,0 +1,54 @@
> +/*
> + *  HID driver for Aureal Cy se W-01RN USB_V3.1 devices
> + *
> + *  Copyright (c) 2010 Franco Catrin <fcatrin@gmail.com>
> + *  Copyright (c) 2010 Ben Cropley <bcropley@internode.on.net>
> + *
> + *  Based on HID sunplus driver by
> + *  Copyright (c) 1999 Andreas Gal
> + *  Copyright (c) 2000-2005 Vojtech Pavlik <vojtech@suse.cz>
> + *  Copyright (c) 2005 Michael Haboustak <mike-@cinci.rr.com> for Concept2, Inc
> + *  Copyright (c) 2006-2007 Jiri Kosina
> + *  Copyright (c) 2007 Paul Walmsley
> + *  Copyright (c) 2008 Jiri Slaby
> + */
> +#include <linux/device.h>
> +#include <linux/hid.h>
> +#include <linux/module.h>
> +
> +#include "hid-ids.h"
> +
> +static __u8 *aureal_report_fixup(struct hid_device *hdev, __u8 *rdesc,
> +		unsigned int *rsize)
> +{
> +	if (*rsize >= 54 && rdesc[52] == 0x25 && rdesc[53] == 0x01) {
> +		dev_info(&hdev->dev, "fixing Aureal Cy se W-01RN USB_V3.1 report descriptor. Keyboard Logical Maximum = 101\n");

This is probably putting a too much information into dmesg. Could you 
please drop the part with the 'Keyboard Logical Maximum ...'?

> +		rdesc[53] = 0x65;
> +	} return rdesc;
> +}
> +
> +static const struct hid_device_id aureal_devices[] = {
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_AUREAL, USB_DEVICE_ID_AUREAL_W01RN) },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(hid, aureal_devices);
> +
> +static struct hid_driver aureal_driver = {
> +	.name = "aureal",
> +	.id_table = aureal_devices,
> +	.report_fixup = aureal_report_fixup,
> +};
> +
> +static int __init aureal_init(void)
> +{
> +	return hid_register_driver(&aureal_driver);
> +}
> +
> +static void __exit aureal_exit(void)
> +{
> +	hid_unregister_driver(&aureal_driver);
> +}
> +
> +module_init(aureal_init);
> +module_exit(aureal_exit);
> +MODULE_LICENSE("GPL");
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 2b67e84..720c9e7 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -154,6 +154,9 @@
>  #define USB_DEVICE_ID_ATMEL_MULTITOUCH	0x211c
>  #define USB_DEVICE_ID_ATMEL_MXT_DIGITIZER	0x2118
>  
> +#define USB_VENDOR_ID_AUREAL		0x0755
> +#define USB_DEVICE_ID_AUREAL_W01RN	0x2626
> +
>  #define USB_VENDOR_ID_AVERMEDIA		0x07ca
>  #define USB_DEVICE_ID_AVER_FM_MR800	0xb800

You don't seem to be adding appropriate entry to 
hid_have_special_driver[].

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 0/3] RESEND Aureal special HID driver
  2012-04-09  0:08 ` Jiri Kosina
@ 2012-04-10 22:29   ` Josenivaldo Benito Junior
  2012-04-13 16:21       ` Jiri Kosina
  2012-04-10 22:29   ` [PATCH 1/3] Aureal Remote Control Device Driver Josenivaldo Benito Junior
                     ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Josenivaldo Benito Junior @ 2012-04-10 22:29 UTC (permalink / raw)
  To: linux-input, linux-kernel, Jiri Kosina
  Cc: Franco Catrin, Josenivaldo Benito Junior

This patch is a RESEND of hid-aureal patch with Jiri´s suggestions applied.
It applies over linux-next-20120410 tag of linux-next tree.

Hid-aureal special HID driver is intend to correct a bogus HID descritor 
reported by Aureal IR based remote controllers.

Josenivaldo Benito Junior (3):
  Aureal Remote Control Device Driver
  HID: hid-core: Adding hid-aureal special driver
  HID: hid-aureal: Removing excessive dmesg information

 drivers/hid/Kconfig      |    6 +++++
 drivers/hid/Makefile     |    1 +
 drivers/hid/hid-aureal.c |   54 ++++++++++++++++++++++++++++++++++++++++++++++
 drivers/hid/hid-core.c   |    1 +
 drivers/hid/hid-ids.h    |    3 ++
 5 files changed, 65 insertions(+), 0 deletions(-)
 create mode 100644 drivers/hid/hid-aureal.c

-- 
1.7.5.4


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/3] Aureal Remote Control Device Driver
  2012-04-09  0:08 ` Jiri Kosina
  2012-04-10 22:29   ` [PATCH 0/3] RESEND Aureal special HID driver Josenivaldo Benito Junior
@ 2012-04-10 22:29   ` Josenivaldo Benito Junior
  2012-04-10 22:29   ` [PATCH 2/3] HID: hid-core: Adding hid-aureal special driver Josenivaldo Benito Junior
  2012-04-10 22:29   ` [PATCH 3/3] HID: hid-aureal: Removing excessive dmesg information Josenivaldo Benito Junior
  3 siblings, 0 replies; 8+ messages in thread
From: Josenivaldo Benito Junior @ 2012-04-10 22:29 UTC (permalink / raw)
  To: linux-input, linux-kernel, Jiri Kosina
  Cc: Franco Catrin, Josenivaldo Benito Junior

Devices like Aureal Cy se W-01RN USB_V3.1 and some derived hardware
have a bogus HID Report Descriptor. According to that report descriptor,
the maximum logical value for key events is 1 and not 101 (101 keys).

This quirk fixes this wrong Report Descriptor and is basically the same found
in hid-elecom.c.

Original driver can be found at: https://gitorious.org/hid-aureal-kernel-module

Signed-off-by: Josenivaldo Benito Junior <jrbenito@benito.qsl.br>
Signed-off-by: Franco Catrin <fcatrin@gmail.com>
---
 drivers/hid/Kconfig      |    6 +++++
 drivers/hid/Makefile     |    1 +
 drivers/hid/hid-aureal.c |   54 ++++++++++++++++++++++++++++++++++++++++++++++
 drivers/hid/hid-ids.h    |    3 ++
 4 files changed, 64 insertions(+), 0 deletions(-)
 create mode 100644 drivers/hid/hid-aureal.c

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 4ecc256..03e2281 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -92,6 +92,12 @@ config HID_APPLE
 	Say Y here if you want support for keyboards of	Apple iBooks, PowerBooks,
 	MacBooks, MacBook Pros and Apple Aluminum.
 
+config HID_AUREAL
+	tristate "Aureal"
+	depends on USB_HID
+	---help---
+	Support for Aureal Cy se W-01RN Remote Controller and other Aureal derived remotes.
+
 config HID_BELKIN
 	tristate "Belkin Flip KVM and Wireless keyboard" if EXPERT
 	depends on USB_HID
diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
index 22f1d16..5363f17 100644
--- a/drivers/hid/Makefile
+++ b/drivers/hid/Makefile
@@ -36,6 +36,7 @@ endif
 obj-$(CONFIG_HID_A4TECH)	+= hid-a4tech.o
 obj-$(CONFIG_HID_ACRUX)		+= hid-axff.o
 obj-$(CONFIG_HID_APPLE)		+= hid-apple.o
+obj-$(CONFIG_HID_AUREAL)        += hid-aureal.o
 obj-$(CONFIG_HID_BELKIN)	+= hid-belkin.o
 obj-$(CONFIG_HID_CHERRY)	+= hid-cherry.o
 obj-$(CONFIG_HID_CHICONY)	+= hid-chicony.o
diff --git a/drivers/hid/hid-aureal.c b/drivers/hid/hid-aureal.c
new file mode 100644
index 0000000..9fb676b
--- /dev/null
+++ b/drivers/hid/hid-aureal.c
@@ -0,0 +1,54 @@
+/*
+ *  HID driver for Aureal Cy se W-01RN USB_V3.1 devices
+ *
+ *  Copyright (c) 2010 Franco Catrin <fcatrin@gmail.com>
+ *  Copyright (c) 2010 Ben Cropley <bcropley@internode.on.net>
+ *
+ *  Based on HID sunplus driver by
+ *  Copyright (c) 1999 Andreas Gal
+ *  Copyright (c) 2000-2005 Vojtech Pavlik <vojtech@suse.cz>
+ *  Copyright (c) 2005 Michael Haboustak <mike-@cinci.rr.com> for Concept2, Inc
+ *  Copyright (c) 2006-2007 Jiri Kosina
+ *  Copyright (c) 2007 Paul Walmsley
+ *  Copyright (c) 2008 Jiri Slaby
+ */
+#include <linux/device.h>
+#include <linux/hid.h>
+#include <linux/module.h>
+
+#include "hid-ids.h"
+
+static __u8 *aureal_report_fixup(struct hid_device *hdev, __u8 *rdesc,
+		unsigned int *rsize)
+{
+	if (*rsize >= 54 && rdesc[52] == 0x25 && rdesc[53] == 0x01) {
+		dev_info(&hdev->dev, "fixing Aureal Cy se W-01RN USB_V3.1 report descriptor. Keyboard Logical Maximum = 101\n");
+		rdesc[53] = 0x65;
+	} return rdesc;
+}
+
+static const struct hid_device_id aureal_devices[] = {
+	{ HID_USB_DEVICE(USB_VENDOR_ID_AUREAL, USB_DEVICE_ID_AUREAL_W01RN) },
+	{ }
+};
+MODULE_DEVICE_TABLE(hid, aureal_devices);
+
+static struct hid_driver aureal_driver = {
+	.name = "aureal",
+	.id_table = aureal_devices,
+	.report_fixup = aureal_report_fixup,
+};
+
+static int __init aureal_init(void)
+{
+	return hid_register_driver(&aureal_driver);
+}
+
+static void __exit aureal_exit(void)
+{
+	hid_unregister_driver(&aureal_driver);
+}
+
+module_init(aureal_init);
+module_exit(aureal_exit);
+MODULE_LICENSE("GPL");
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 2b67e84..720c9e7 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -154,6 +154,9 @@
 #define USB_DEVICE_ID_ATMEL_MULTITOUCH	0x211c
 #define USB_DEVICE_ID_ATMEL_MXT_DIGITIZER	0x2118
 
+#define USB_VENDOR_ID_AUREAL		0x0755
+#define USB_DEVICE_ID_AUREAL_W01RN	0x2626
+
 #define USB_VENDOR_ID_AVERMEDIA		0x07ca
 #define USB_DEVICE_ID_AVER_FM_MR800	0xb800
 
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/3] HID: hid-core: Adding hid-aureal special driver
  2012-04-09  0:08 ` Jiri Kosina
  2012-04-10 22:29   ` [PATCH 0/3] RESEND Aureal special HID driver Josenivaldo Benito Junior
  2012-04-10 22:29   ` [PATCH 1/3] Aureal Remote Control Device Driver Josenivaldo Benito Junior
@ 2012-04-10 22:29   ` Josenivaldo Benito Junior
  2012-04-10 22:29   ` [PATCH 3/3] HID: hid-aureal: Removing excessive dmesg information Josenivaldo Benito Junior
  3 siblings, 0 replies; 8+ messages in thread
From: Josenivaldo Benito Junior @ 2012-04-10 22:29 UTC (permalink / raw)
  To: linux-input, linux-kernel, Jiri Kosina
  Cc: Franco Catrin, Josenivaldo Benito Junior

Add the hid-aureal special driver to hid-core. This avoid the necessity
of load module hid-aureal before module usbhid.

Signed-off-by: Josenivaldo Benito Junior <jrbenito@benito.qsl.br>
---
 drivers/hid/hid-core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 94f0343..107a731 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1387,6 +1387,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ASUS, USB_DEVICE_ID_ASUS_T91MT) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ASUS, USB_DEVICE_ID_ASUSTEK_MULTITOUCH_YFO) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_AUREAL, USB_DEVICE_ID_AUREAL_W01RN) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_BELKIN, USB_DEVICE_ID_FLIP_KVM) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_BTC, USB_DEVICE_ID_BTC_EMPREX_REMOTE) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_BTC, USB_DEVICE_ID_BTC_EMPREX_REMOTE_2) },
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 3/3] HID: hid-aureal: Removing excessive dmesg information
  2012-04-09  0:08 ` Jiri Kosina
                     ` (2 preceding siblings ...)
  2012-04-10 22:29   ` [PATCH 2/3] HID: hid-core: Adding hid-aureal special driver Josenivaldo Benito Junior
@ 2012-04-10 22:29   ` Josenivaldo Benito Junior
  3 siblings, 0 replies; 8+ messages in thread
From: Josenivaldo Benito Junior @ 2012-04-10 22:29 UTC (permalink / raw)
  To: linux-input, linux-kernel, Jiri Kosina
  Cc: Franco Catrin, Josenivaldo Benito Junior

Avoid excessive dmesg verbosity as per Jiri´s suggestion.

Signed-off-by: Josenivaldo Benito Junior <jrbenito@benito.qsl.br>
---
 drivers/hid/hid-aureal.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/hid/hid-aureal.c b/drivers/hid/hid-aureal.c
index 9fb676b..ba64b04 100644
--- a/drivers/hid/hid-aureal.c
+++ b/drivers/hid/hid-aureal.c
@@ -22,7 +22,7 @@ static __u8 *aureal_report_fixup(struct hid_device *hdev, __u8 *rdesc,
 		unsigned int *rsize)
 {
 	if (*rsize >= 54 && rdesc[52] == 0x25 && rdesc[53] == 0x01) {
-		dev_info(&hdev->dev, "fixing Aureal Cy se W-01RN USB_V3.1 report descriptor. Keyboard Logical Maximum = 101\n");
+		dev_info(&hdev->dev, "fixing Aureal Cy se W-01RN USB_V3.1 report descriptor.\n");
 		rdesc[53] = 0x65;
 	} return rdesc;
 }
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/3] RESEND Aureal special HID driver
  2012-04-10 22:29   ` [PATCH 0/3] RESEND Aureal special HID driver Josenivaldo Benito Junior
@ 2012-04-13 16:21       ` Jiri Kosina
  0 siblings, 0 replies; 8+ messages in thread
From: Jiri Kosina @ 2012-04-13 16:21 UTC (permalink / raw)
  To: Josenivaldo Benito Junior; +Cc: linux-input, linux-kernel, Franco Catrin

On Tue, 10 Apr 2012, Josenivaldo Benito Junior wrote:

> This patch is a RESEND of hid-aureal patch with Jiri´s suggestions applied.
> It applies over linux-next-20120410 tag of linux-next tree.
> 
> Hid-aureal special HID driver is intend to correct a bogus HID descritor 
> reported by Aureal IR based remote controllers.
> 
> Josenivaldo Benito Junior (3):
>   Aureal Remote Control Device Driver
>   HID: hid-core: Adding hid-aureal special driver
>   HID: hid-aureal: Removing excessive dmesg information

Folded into one patch and applied, thanks.

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/3] RESEND Aureal special HID driver
@ 2012-04-13 16:21       ` Jiri Kosina
  0 siblings, 0 replies; 8+ messages in thread
From: Jiri Kosina @ 2012-04-13 16:21 UTC (permalink / raw)
  To: Josenivaldo Benito Junior; +Cc: linux-input, linux-kernel, Franco Catrin

On Tue, 10 Apr 2012, Josenivaldo Benito Junior wrote:

> This patch is a RESEND of hid-aureal patch with Jiri´s suggestions applied.
> It applies over linux-next-20120410 tag of linux-next tree.
> 
> Hid-aureal special HID driver is intend to correct a bogus HID descritor 
> reported by Aureal IR based remote controllers.
> 
> Josenivaldo Benito Junior (3):
>   Aureal Remote Control Device Driver
>   HID: hid-core: Adding hid-aureal special driver
>   HID: hid-aureal: Removing excessive dmesg information

Folded into one patch and applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2012-04-13 16:21 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-30 21:08 [PATCH] Aureal Remote Control Device Driver Josenivaldo Benito Junior
2012-04-09  0:08 ` Jiri Kosina
2012-04-10 22:29   ` [PATCH 0/3] RESEND Aureal special HID driver Josenivaldo Benito Junior
2012-04-13 16:21     ` Jiri Kosina
2012-04-13 16:21       ` Jiri Kosina
2012-04-10 22:29   ` [PATCH 1/3] Aureal Remote Control Device Driver Josenivaldo Benito Junior
2012-04-10 22:29   ` [PATCH 2/3] HID: hid-core: Adding hid-aureal special driver Josenivaldo Benito Junior
2012-04-10 22:29   ` [PATCH 3/3] HID: hid-aureal: Removing excessive dmesg information Josenivaldo Benito Junior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.