All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Simon Wood <simon@mungewell.org>
Cc: "Anssi Hannula" <anssi.hannula@iki.fi>,
	linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
	"Elias Vanderstuyft" <elias.vds@gmail.com>,
	stable@vger.kernel.org, "\"Michal Malý\"" <madcatxster@prifuk.cz>
Subject: Re: [PATCH] HID: logitech - lg2ff: Add IDs for Formula Vibration Feedback Wheel
Date: Wed, 9 Oct 2013 12:09:34 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.00.1310091208260.13289@pobox.suse.cz> (raw)
In-Reply-To: <cec1e0ca61cf17ceb6e52faa4f2baad9.squirrel@mungewell.org>

On Mon, 7 Oct 2013, simon@mungewell.org wrote:

> > The lg2ff force feedback subdriver is used for vibration and
> > HID_GD_MULTIAXIS is set to avoid deadzone like other Logitech wheels.
> >
> > Kconfig description etc are also updated accordingly.
> >
> > Signed-off-by: Elias Vanderstuyft <Elias.vds@gmail.com>
> > [anssi.hannula@iki.fi: added description and CCs]
> > Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi>
> > Cc: Simon Wood <simon@mungewell.org>
> > Cc: <stable@vger.kernel.org>
> > ---
> >
> > Simon, does this look OK to you, or do you think it should be an lg4ff
> > device? Though I guess lg2ff is better than nothing even in that case.
> 
> Signed-off-by: Simon Wood <simon@mungewell.org>

Thanks, I have now applied the patch. In case you are going to work 
further on splitting break/accel into different axes, please send it as a 
followup patch.

Thanks.

-- 
Jiri Kosina
SUSE Labs

      parent reply	other threads:[~2013-10-09 10:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-07 16:48 [PATCH] HID: logitech - lg2ff: Add IDs for Formula Vibration Feedback Wheel Anssi Hannula
     [not found] ` <1381164492-27145-1-git-send-email-anssi.hannula-X3B1VOXEql0@public.gmane.org>
2013-10-07 17:48   ` simon-wM4F9T/ekXmXDw4h08c5KA
2013-10-07 17:56     ` Anssi Hannula
     [not found]       ` <CADbOyBSry1eFsCycM-BaDEhaA7_+JUBpYZEqA4s5s-g2vq5whg@mail.gmail.com>
2013-10-07 20:03         ` simon
     [not found]           ` <fa1af5a9ba814114ddf5ee8fe65b8b4b.squirrel-uf5OtEnyChf6gvvhDbwh+ti2O/JbrIOy@public.gmane.org>
2013-10-08 10:00             ` Michal Malý
2013-10-08 18:24               ` simon
2013-10-09 10:09     ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1310091208260.13289@pobox.suse.cz \
    --to=jkosina@suse.cz \
    --cc=anssi.hannula@iki.fi \
    --cc=elias.vds@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=madcatxster@prifuk.cz \
    --cc=simon@mungewell.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.