All of lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: Skip namespaces with interleaved meta-data
Date: Thu, 29 Jan 2015 00:09:44 +0000 (UTC)	[thread overview]
Message-ID: <alpine.LNX.2.00.1501282232380.15481@localhost.lm.intel.com> (raw)
In-Reply-To: <yq1egqeilpi.fsf@sermon.lab.mkp.net>

On Wed, 28 Jan 2015, Martin K. Petersen wrote:
>>>>>> "Keith" == Keith Busch <keith.busch at intel.com> writes:
> Keith> That's an option for a subset of formats I eluded to before. It
> Keith> will have the controller generate/strip if the metadata size 8
> Keith> bytes with DPS settings, but ignored otherwise. We still need a
> Keith> buffer if metadata is not used for PI, or if the metadata size
> Keith> more than 8 bytes.
>
> I agree it's a deficiency in the NVMe spec that there are no explicit
> handling flags for non-PI metadata in split mode.

Yeah, it is pretty bad. Pressing forward though, I'm working on something
that might be suitable, but hitting another problem using integrity
extensions with blk-mq.

Jens,
Integrity verify is broken in here. blk_mq_end_request() calls
blk_update_request(), which moves the bio iterator to the end.
When we get to bio_integrity_process(), there's nothing for it to do,
so verification is skipped.

Should I look into this, or do you have a good idea how to fix that?

  reply	other threads:[~2015-01-29  0:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 18:07 [PATCH] NVMe: Skip namespaces with interleaved meta-data Keith Busch
2015-01-27 21:57 ` David Darrington
2015-01-27 22:09   ` Keith Busch
2015-01-28  1:21     ` Keith Busch
2015-01-28  1:39       ` Martin K. Petersen
2015-01-28 15:11         ` Keith Busch
2015-01-28 20:50           ` Paul Grabinar
2015-01-28 21:16             ` Keith Busch
2015-01-28 21:46               ` Paul Grabinar
2015-01-28 22:08                 ` Martin K. Petersen
2015-01-28 22:17                   ` Keith Busch
2015-01-28 22:28                     ` Martin K. Petersen
2015-01-29  0:09                       ` Keith Busch [this message]
2015-01-29  0:57                         ` Martin K. Petersen
2015-01-29 15:44                           ` Keith Busch
2015-01-30  0:41                             ` Martin K. Petersen
2015-01-30  0:57                               ` Keith Busch
2015-01-28 22:17           ` Andrey Kuzmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1501282232380.15481@localhost.lm.intel.com \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.