Re: [PATCH 1/2] livepatch: remove unnecessary call to klp_find_object_module()

From: Jiri Kosina <jkosina@suse.cz>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Petr Mladek <pmladek@suse.cz>,
	Seth Jennings <sjenning@redhat.com>,
	Vojtech Pavlik <vojtech@suse.cz>,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	Miroslav Benes <mbenes@suse.cz>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	mingo@kernel.org, mathieu.desnoyers@efficios.com,
	oleg@redhat.com, paulmck@linux.vnet.ibm.com, andi@firstfloor.org,
	rostedt@goodmis.org, tglx@linutronix.de
Subject: Re: [PATCH 1/2] livepatch: remove unnecessary call to klp_find_object_module()
Date: Wed, 4 Mar 2015 22:48:40 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.1503042248150.26925@pobox.suse.cz> (raw)
In-Reply-To: <4bf3b9f8329b0a6b47747ffe5549de34b4be591d.1425423640.git.jpoimboe@redhat.com>

On Tue, 3 Mar 2015, Josh Poimboeuf wrote:

> klp_find_object_module() is called from both the klp register and enable
> paths.  Only the call from the register path is necessary because the
> module notifier will let us know if the patched module gets loaded or
> unloaded.
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

Applied to for-4.1/core.

> ---
>  kernel/livepatch/core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> index 01ca088..a74e4e8 100644
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -541,8 +541,6 @@ static int __klp_enable_patch(struct klp_patch *patch)
>  	pr_notice("enabling patch '%s'\n", patch->mod->name);
>  
>  	for (obj = patch->objs; obj->funcs; obj++) {
> -		klp_find_object_module(obj);
> -
>  		if (!klp_is_object_loaded(obj))
>  			continue;
>  

-- 
Jiri Kosina
SUSE Labs