From: Jiri Kosina <jkosina@suse.cz>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Gabriele Mazzotta <gabriele.mzt@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: Do not fail probing if gpiolib is not enabled
Date: Thu, 23 Apr 2015 10:58:59 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1504231058450.3695@pobox.suse.cz> (raw)
In-Reply-To: <1429022112-231578-1-git-send-email-mika.westerberg@linux.intel.com>
On Tue, 14 Apr 2015, Mika Westerberg wrote:
> Using GPIOs and gpiolib is optional. If the kernel is compiled without GPIO
> support the driver should not fail if it finds the interrupt using normal
> methods.
>
> However, commit a485923efbb8 ("HID: i2c-hid: Add support for ACPI GPIO
> interrupts") did not take into account that acpi_dev_add_driver_gpios()
> returns -ENXIO when !CONFIG_GPIOLIB.
>
> Fix this by checking the return value against -ENXIO and 0 and only in that
> case fail the probe.
>
> Reported-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
I have applied this to for-4.1/upstream-fixes.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2015-04-23 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 22:55 Hidden dependency of i2c-hid on GPIOLIB Gabriele Mazzotta
2015-04-14 9:59 ` Mika Westerberg
2015-04-14 10:03 ` Gabriele Mazzotta
2015-04-14 14:35 ` [PATCH] HID: i2c-hid: Do not fail probing if gpiolib is not enabled Mika Westerberg
2015-04-23 8:58 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1504231058450.3695@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=benjamin.tissoires@redhat.com \
--cc=gabriele.mzt@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.