From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ylj84-0003Ym-Q2 for qemu-devel@nongnu.org; Fri, 24 Apr 2015 15:19:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ylj81-0002hw-KQ for qemu-devel@nongnu.org; Fri, 24 Apr 2015 15:19:12 -0400 Received: from mga01.intel.com ([192.55.52.88]:45373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ylj81-0002hb-F6 for qemu-devel@nongnu.org; Fri, 24 Apr 2015 15:19:09 -0400 Date: Fri, 24 Apr 2015 19:19:06 +0000 (UTC) From: Keith Busch In-Reply-To: <553A91AE.10708@wendan.org> Message-ID: References: <553A91AE.10708@wendan.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [Qemu-devel] [PATCH] Enable NVMe start controller for Windows guest. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Daniel Stekloff Cc: keith.busch@intel.com, kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Fri, 24 Apr 2015, Daniel Stekloff wrote: > Windows seems to send two separate calls to NVMe controller configuration. The > first sends configuration info and the second the enable bit. I couldn't > enable the Windows 8.1 in-box NVMe driver with base Qemu. I made the > following change to store the configuration data and then handle enable and > NVMe driver works on Windows 8.1. Hm, Microsoft's driver must be issuing MMIO reads to mask in the enable bit rather than keep the state known. Sounds odd, but thanks for the fix. Acked-by: Keith Busch