From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Osmialowski Subject: Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC Date: Thu, 2 Jul 2015 23:42:18 +0200 (CEST) Message-ID: References: <1435667250-28299-1-git-send-email-pawelo@king.net.pl> <1861313.aMcV1xHCIq@wuerfel> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Return-path: In-Reply-To: <1861313.aMcV1xHCIq@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Paul Osmialowski , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Greg Kroah-Hartman , Ian Campbell , Jiri Slaby , Kumar Gala , Linus Walleij , Mark Rutland , Michael Turquette , Pawel Moll , Rob Herring , Russell King , Stephen Boyd , Vinod Koul , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Nicolas Pitre , Sergei Poselenov , Paul Bolle , Jingchang Lu , Yuri List-Id: linux-gpio@vger.kernel.org Hi Arnd, On Thu, 2 Jul 2015, Arnd Bergmann wrote: > I wonder if you could move out the fixed rate clocks into their own > nodes. Are they actually controlled by the same block? If they are > just fixed, you can use the normal binding for fixed rate clocks > and only describe the clocks that are related to the driver. > > Arnd > In my view having these clocks grouped together looks more convincing. After all, they all share the same I/O regs in order to read configuration. Thanks, Paul -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754337AbbGBVte (ORCPT ); Thu, 2 Jul 2015 17:49:34 -0400 Received: from fish.king.net.pl ([79.190.246.46]:59978 "EHLO king.net.pl" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751615AbbGBVtY (ORCPT ); Thu, 2 Jul 2015 17:49:24 -0400 Date: Thu, 2 Jul 2015 23:42:18 +0200 (CEST) From: Paul Osmialowski X-X-Sender: newchief@localhost.localdomain To: Arnd Bergmann cc: Paul Osmialowski , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Ian Campbell , Jiri Slaby , Kumar Gala , Linus Walleij , Mark Rutland , Michael Turquette , Pawel Moll , Rob Herring , Russell King , Stephen Boyd , Vinod Koul , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Nicolas Pitre , Sergei Poselenov , Paul Bolle , Jingchang Lu , Yuri Tikhonov , Rob Herring , Geert Uytterhoeven , Uwe Kleine-Koenig , Alexander Potashev , Frank Li , Thomas Gleixner , Anson Huang Subject: Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC In-Reply-To: <1861313.aMcV1xHCIq@wuerfel> Message-ID: References: <1435667250-28299-1-git-send-email-pawelo@king.net.pl> <1861313.aMcV1xHCIq@wuerfel> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Thu, 2 Jul 2015, Arnd Bergmann wrote: > I wonder if you could move out the fixed rate clocks into their own > nodes. Are they actually controlled by the same block? If they are > just fixed, you can use the normal binding for fixed rate clocks > and only describe the clocks that are related to the driver. > > Arnd > In my view having these clocks grouped together looks more convincing. After all, they all share the same I/O regs in order to read configuration. Thanks, Paul From mboxrd@z Thu Jan 1 00:00:00 1970 From: pawelo@king.net.pl (Paul Osmialowski) Date: Thu, 2 Jul 2015 23:42:18 +0200 (CEST) Subject: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC In-Reply-To: <1861313.aMcV1xHCIq@wuerfel> References: <1435667250-28299-1-git-send-email-pawelo@king.net.pl> <1861313.aMcV1xHCIq@wuerfel> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnd, On Thu, 2 Jul 2015, Arnd Bergmann wrote: > I wonder if you could move out the fixed rate clocks into their own > nodes. Are they actually controlled by the same block? If they are > just fixed, you can use the normal binding for fixed rate clocks > and only describe the clocks that are related to the driver. > > Arnd > In my view having these clocks grouped together looks more convincing. After all, they all share the same I/O regs in order to read configuration. Thanks, Paul