From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753574AbbGVWBc (ORCPT ); Wed, 22 Jul 2015 18:01:32 -0400 Received: from [89.191.203.168] ([89.191.203.168]:53201 "EHLO mail.emea.novell.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752797AbbGVWBb (ORCPT ); Wed, 22 Jul 2015 18:01:31 -0400 Date: Thu, 23 Jul 2015 00:01:27 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Dmitry Torokhov cc: Vlastimil Babka , Samuel Thibault , Pavel Machek , =?ISO-8859-15?Q?Pali_Roh=E1r?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, rpurdie@rpsys.net, Greg Kroah-Hartman Subject: Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs In-Reply-To: <20150722214948.GF14875@dtor-ws> Message-ID: References: <1433799790-31873-1-git-send-email-dmitry.torokhov@gmail.com> <1433799790-31873-2-git-send-email-dmitry.torokhov@gmail.com> <20150609174211.GH6338@dtor-ws> <55AE299F.3010002@suse.cz> <20150721170133.GA39076@dtor-ws> <55AFAB9B.2090101@suse.cz> <20150722214948.GF14875@dtor-ws> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Jul 2015, Dmitry Torokhov wrote: > Yes, I'll change how we count the leds to skip unnamed, then the patch > below won't be needed. Agreed. > BTW, maybe we should be using hid_map_usage_clear() in map_led() as it > does not make much sense to convert CAPS LOCK into SCROLL LOCK in case > keyboard happens to have 2 usages for caps... Indeed, makes sense generally for all LEDs I think. -- Jiri Kosina SUSE Labs