From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932156AbbKLKXv (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 Nov 2015 05:23:51 -0500
Received: from mx2.suse.de ([195.135.220.15]:46984 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754195AbbKLKXs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 Nov 2015 05:23:48 -0500
Date: Thu, 12 Nov 2015 11:23:48 +0100 (CET)
From: Miroslav Benes <mbenes@suse.cz>
To: Chris J Arges <chris.j.arges@canonical.com>
cc: live-patching@vger.kernel.org, jeyu@redhat.com,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Seth Jennings <sjenning@redhat.com>, Jiri Kosina <jikos@kernel.org>,
        Vojtech Pavlik <vojtech@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field
 to klp_reloc
In-Reply-To: <1447259366-7055-3-git-send-email-chris.j.arges@canonical.com>
Message-ID: <alpine.LNX.2.00.1511121122560.9440@pobox.suse.cz>
References: <20151103200608.GQ27488@treble.redhat.com> <1447259366-7055-1-git-send-email-chris.j.arges@canonical.com> <1447259366-7055-3-git-send-email-chris.j.arges@canonical.com>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 11 Nov 2015, Chris J Arges wrote:

> In cases of duplicate symbols, sympos will be used to disambiguate instead
> of val. By default old_sympos will be 0, and patching will only succeed if
> the symbol is unique. Specifying a positive value will ensure that
> occurrence of the symbol will be used for patching if it is valid.

Again "...occurrence of the symbol in kallsyms for the patched object 
will be used..."

>  2 files changed, 18 insertions(+), 61 deletions(-)

And this is indeed great.

Miroslav