From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754488AbbKMJ46 (ORCPT ); Fri, 13 Nov 2015 04:56:58 -0500 Received: from mx2.suse.de ([195.135.220.15]:50853 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752944AbbKMJ4y (ORCPT ); Fri, 13 Nov 2015 04:56:54 -0500 Date: Fri, 13 Nov 2015 10:56:53 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Chris J Arges cc: live-patching@vger.kernel.org, jeyu@redhat.com, Josh Poimboeuf , Seth Jennings , Vojtech Pavlik , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4 v5] livepatch: add old_sympos as disambiguator field to klp_func In-Reply-To: <1447347595-30728-2-git-send-email-chris.j.arges@canonical.com> Message-ID: References: <1447259366-7055-1-git-send-email-chris.j.arges@canonical.com> <1447347595-30728-1-git-send-email-chris.j.arges@canonical.com> <1447347595-30728-2-git-send-email-chris.j.arges@canonical.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Nov 2015, Chris J Arges wrote: > In cases of duplicate symbols, old_sympos will be used to disambiguate > instead of old_addr. By default old_sympos will be 0, and patching will > only succeed if the symbol is unique. Specifying a positive value will > ensure that occurrence of the symbol in kallsyms for the patched object > will be used for patching if it is valid. > > In addition, make old_addr an internal structure field not to be specified > by the user. Finally, remove klp_find_verify_func_addr as it can be > replaced by klp_find_object_symbol directly. The changelog has to cover the "why is this better than previous aproach". It's neither in the cover letter (that by default doesn't make it into changelog anyway) nor in either of the commit logs. Thanks, -- Jiri Kosina SUSE Labs