From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932286AbbLNMpK (ORCPT ); Mon, 14 Dec 2015 07:45:10 -0500 Received: from mx2.suse.de ([195.135.220.15]:36506 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752825AbbLNMpJ (ORCPT ); Mon, 14 Dec 2015 07:45:09 -0500 Date: Mon, 14 Dec 2015 13:45:06 +0100 (CET) From: Miroslav Benes To: Chris J Arges cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, jikos@kernel.org, pmladek@suse.com, jeyu@redhat.com, Seth Jennings , Vojtech Pavlik Subject: Re: [PATCH 2/3 v9] livepatch: add sympos as disambiguator field to klp_reloc In-Reply-To: <1449024076-16034-3-git-send-email-chris.j.arges@canonical.com> Message-ID: References: <1448040325-32498-1-git-send-email-chris.j.arges@canonical.com> <1449024076-16034-1-git-send-email-chris.j.arges@canonical.com> <1449024076-16034-3-git-send-email-chris.j.arges@canonical.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Dec 2015, Chris J Arges wrote: > In cases of duplicate symbols, sympos will be used to disambiguate instead > of val. By default sympos will be 0, and patching will only succeed if > the symbol is unique. Specifying a positive value will ensure that > occurrence of the symbol in kallsyms for the patched object will be used > for patching if it is valid. For external relocations sympos is not > supported. > > Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol > as they are no longer used. > > >From the klp_reloc structure remove val, as it can be refactored as a > local variable in klp_write_object_relocations. > > Signed-off-by: Chris J Arges FWIW Reviewed-by: Miroslav Benes Miroslav