From: Finn Thain <fthain@telegraphics.com.au>
To: Christoph Hellwig <hch@infradead.org>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Michael Schmitz <schmitzmic@gmail.com>,
linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Ondrej Zary <linux@rainbow-software.org>,
Sam Creasey <sammy@sammy.net>
Subject: Re: [PATCH 14/22] ncr5380: Add MAX_LUN limit
Date: Tue, 15 Mar 2016 14:20:55 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.00.1603151341080.9662@nippy.intranet> (raw)
In-Reply-To: <20160314075112.GA19372@infradead.org>
On Mon, 14 Mar 2016, Christoph Hellwig wrote:
> On Mon, Mar 14, 2016 at 03:27:14PM +1100, Finn Thain wrote:
> > The driver has a limit of eight LUs because of the byte-sized bitfield
> > that is used for busy flags. Reject commands with LUN > 7.
>
> Please just set the max_lun parameter in the host template, which will
> take care of this.
The reason I didn't do that initially was that I could not convince myself
that all command submission paths would enforce the shost->max_lun limit.
But I'll take your word for it.
I don't think the host template is the right place for this (there are
about ten of these that would need to be changed anyway) because
scsi_host_alloc() assigns shost->max_lun = 8. So I'll add the
instance->max_lun = 7 assignment to NCR5380_init().
--
next prev parent reply other threads:[~2016-03-15 3:21 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 4:27 [PATCH 00/22] ncr5380: Eliminate macros, reduce code duplication, fix bugs etc Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 4:27 ` [PATCH 01/22] g_ncr5380: Remove CONFIG_SCSI_GENERIC_NCR53C400 Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:21 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 02/22] ncr5380: Remove FLAG_NO_PSEUDO_DMA where possible Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:21 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 03/22] ncr5380: Remove REAL_DMA and REAL_DMA_POLL macros Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:23 ` Hannes Reinecke
2016-03-14 7:23 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 04/22] atari_NCR5380: Remove DMA_MIN_SIZE macro Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:25 ` Hannes Reinecke
2016-03-14 7:25 ` Hannes Reinecke
2016-03-15 3:18 ` Finn Thain
2016-03-14 4:27 ` [PATCH 05/22] ncr5380: Disable the DMA errata workaround flag by default Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:26 ` Hannes Reinecke
2016-03-14 7:26 ` Hannes Reinecke
2016-03-14 7:26 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 06/22] ncr5380: Remove PSEUDO_DMA macro Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:28 ` Hannes Reinecke
2016-03-14 7:28 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 07/22] ncr5380: Remove BOARD_REQUIRES_NO_DELAY macro Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:33 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 08/22] ncr5380: Use DMA hooks for PDMA Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:34 ` Hannes Reinecke
2016-03-14 7:34 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:36 ` Hannes Reinecke
2016-03-14 7:36 ` Hannes Reinecke
2016-03-15 3:19 ` Finn Thain
2016-03-15 3:19 ` Finn Thain
2016-03-15 6:49 ` Hannes Reinecke
2016-03-15 6:49 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 10/22] ncr5380: Merge DMA implementation from atari_NCR5380 core driver Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:38 ` Hannes Reinecke
2016-03-14 7:38 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 11/22] atari_scsi: Adopt NCR5380.c " Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:39 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 12/22] sun3_scsi: " Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:40 ` Hannes Reinecke
2016-03-14 7:40 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 13/22] ncr5380: Remove disused atari_NCR5380.c " Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:42 ` Hannes Reinecke
2016-03-14 7:42 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 14/22] ncr5380: Add MAX_LUN limit Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:43 ` Hannes Reinecke
2016-03-14 7:51 ` Christoph Hellwig
2016-03-15 3:20 ` Finn Thain [this message]
2016-03-15 8:26 ` Christoph Hellwig
2016-03-14 4:27 ` [PATCH 15/22] dmx3191d: Drop max_sectors limit Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:43 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 16/22] ncr5380: Fix register decoding for debugging Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:46 ` Hannes Reinecke
2016-03-15 3:21 ` Finn Thain
2016-03-14 4:27 ` [PATCH 17/22] ncr5380: Remove remaining register storage qualifiers Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:46 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 18/22] ncr5380: Remove DONT_USE_INTR and AUTOPROBE_IRQ macros Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:47 ` Hannes Reinecke
2016-03-14 7:47 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 19/22] ncr5380: Update usage documentation Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:47 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 20/22] atari_scsi: Set a reasonable default for cmd_per_lun Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:49 ` Hannes Reinecke
2016-03-15 3:27 ` Finn Thain
2016-03-15 6:53 ` Hannes Reinecke
2016-03-15 8:27 ` Finn Thain
2016-03-15 14:34 ` James Bottomley
2016-03-14 4:27 ` [PATCH 21/22] atari_scsi: Allow can_queue to be increased for Falcon Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:58 ` Hannes Reinecke
2016-03-14 7:58 ` Hannes Reinecke
2016-03-14 4:27 ` [PATCH 22/22] mac_scsi: Fix pseudo DMA implementation Finn Thain
2016-03-14 4:27 ` Finn Thain
2016-03-14 7:59 ` Hannes Reinecke
2016-03-18 7:03 ` [PATCH 00/22] ncr5380: Eliminate macros, reduce code duplication, fix bugs etc Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1603151341080.9662@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=martin.petersen@oracle.com \
--cc=sammy@sammy.net \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.