From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756064AbcCUNtS (ORCPT ); Mon, 21 Mar 2016 09:49:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:54477 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754861AbcCUNtN (ORCPT ); Mon, 21 Mar 2016 09:49:13 -0400 Date: Mon, 21 Mar 2016 14:49:11 +0100 (CET) From: Miroslav Benes To: Jessica Yu cc: Rusty Russell , Josh Poimboeuf , Petr Mladek , Jiri Kosina , Jonathan Corbet , linux-api@vger.kernel.org, live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v5 3/6] module: s390: keep mod_arch_specific for livepatch modules In-Reply-To: <1458157628-8264-4-git-send-email-jeyu@redhat.com> Message-ID: References: <1458157628-8264-1-git-send-email-jeyu@redhat.com> <1458157628-8264-4-git-send-email-jeyu@redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Mar 2016, Jessica Yu wrote: > Livepatch needs to utilize the symbol information contained in the > mod_arch_specific struct in order to be able to call the s390 > apply_relocate_add() function to apply relocations. Keep a reference to > syminfo if the module is a livepatch module. Remove the redundant vfree() > in module_finalize() since module_arch_freeing_init() (which also frees > those structures) is called in do_init_module(). If the module isn't a > livepatch module, we free the structures in module_arch_freeing_init() as > usual. > > Signed-off-by: Jessica Yu Reviewed-by: Miroslav Benes