From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752428AbcFVNZa (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Jun 2016 09:25:30 -0400
Received: from mx2.suse.de ([195.135.220.15]:50967 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752305AbcFVNZW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Jun 2016 09:25:22 -0400
Date: Wed, 22 Jun 2016 15:25:19 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
X-X-Sender: jkosina@pobox.suse.cz
To: Heiner Kallweit <hkallweit1@gmail.com>
cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: Re: [PATCH 4/4] HID: remove ThingM blink(1) driver
In-Reply-To: <f8c59082-d76c-73aa-70b6-7454b731a055@gmail.com>
Message-ID: <alpine.LNX.2.00.1606221520340.6874@cbobk.fhfr.pm>
References: <f8c59082-d76c-73aa-70b6-7454b731a055@gmail.com>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 21 Jun 2016, Heiner Kallweit wrote:

> Now that support for ThingM blink(1) was merged into the hid-led driver
> the dedicated driver for this device can be removed.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/hid/Kconfig      |  10 --
>  drivers/hid/Makefile     |   1 -
>  drivers/hid/hid-thingm.c | 259 -----------------------------------------------
>  3 files changed, 270 deletions(-)
>  delete mode 100644 drivers/hid/hid-thingm.c
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index ab22090..6b08a3b 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -828,16 +828,6 @@ config HID_TOPSEED
>  	Say Y if you have a TopSeed Cyberlink or BTC Emprex or Conceptronic
>  	CLLRCMCE remote control.
>  
> -config HID_THINGM

Overall the patchset looks good to me. I'd suggest we keep 
CONFIG_HID_THINGM as a stub though, that'd just select CONFIG_HID_LED, so 
that we don't cause kernel config regressions for users who had 
CONFIG_HID_THINGM already turned on.

Also adding Vivien Didelot to CC, as the author of the original driver. 
Vivien, the full set can be found in linux-input archives ( 
http://marc.info/?l=linux-input&r=1&b=201606&w=2 )

-- 
Jiri Kosina
SUSE Labs