From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933980AbcJUM4l (ORCPT ); Fri, 21 Oct 2016 08:56:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:57248 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933485AbcJUM4i (ORCPT ); Fri, 21 Oct 2016 08:56:38 -0400 Date: Fri, 21 Oct 2016 14:56:33 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Eric Dumazet cc: Jamal Hadi Salim , Phil Sutter , Cong Wang , Daniel Borkmann , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump In-Reply-To: <1477049817.7065.56.camel@edumazet-glaptop3.roam.corp.google.com> Message-ID: References: <1477049817.7065.56.camel@edumazet-glaptop3.roam.corp.google.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Oct 2016, Eric Dumazet wrote: > Some of us are dealing with huge HTB hierarchies, so adding default fifo > in the dump will add more data pumped from the kernel. > > BwE [1] for instance dumps qdisc/classes every 5 seconds. > > I guess we'll need to not pull this patch in our kernels. Okay, so I probably misunderstood you here: https://marc.info/?l=linux-kernel&m=146073234818214&w=2 as I thought that as long as we move towards the hashtable, you wouldn't have any issues with this. I'd really like to unhide the default qdiscs, it makes little sense to be inconsistent in this way. Random shot into darkness -- how about making this a CONFIG/sysctl-selectable? Thanks, -- Jiri Kosina SUSE Labs