All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@medozas.de>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Patrick McHardy <kaber@trash.net>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables: fix the dead loop when meeting unknown options
Date: Thu, 14 Apr 2011 09:20:02 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.01.1104140919470.30983@obet.zrqbmnf.qr> (raw)
In-Reply-To: <1300083811-27146-1-git-send-email-xiaosuo@gmail.com>

On Monday 2011-03-14 07:23, Changli Gao wrote:

>Signed-off-by: Changli Gao <xiaosuo@gmail.com>
>---
> xshared.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>diff --git a/xshared.c b/xshared.c
>index 404a9f5..87402b4 100644
>--- a/xshared.c
>+++ b/xshared.c
>@@ -92,7 +92,7 @@ static bool should_load_proto(struct iptables_command_state *cs)
> 	if (find_proto(cs->protocol, XTF_DONT_LOAD,
> 	    cs->options & OPT_NUMERIC, NULL) == NULL)
> 		return true;
>-	return cs->proto_used;
>+	return !cs->proto_used;
> }

Could you, for completeness, give the command that causes the infinite 
loop?

thanks,
Jan

  reply	other threads:[~2011-04-14  7:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-14  6:23 [PATCH] iptables: fix the dead loop when meeting unknown options Changli Gao
2011-04-14  7:20 ` Jan Engelhardt [this message]
2011-04-14  7:30   ` Changli Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.01.1104140919470.30983@obet.zrqbmnf.qr \
    --to=jengelh@medozas.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=xiaosuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.