All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@medozas.de>
To: Julien Lafaye <jlafaye@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: Packet statistics accounting module: request for comments
Date: Tue, 4 Oct 2011 22:27:12 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.01.1110042220390.10811@frira.zrqbmnf.qr> (raw)
In-Reply-To: <CAFAca_CH4QD-7XngGE=H_pTKo+gN3F_nf2RTf+1S8kbvPXkj-g@mail.gmail.com>

On Tuesday 2011-10-04 21:03, Julien Lafaye wrote:
>
>My objective was to count incoming packets & bytes received during 
>short time frames,[...] So, I chose to build time buckets directly in 
>the softirq handler and export them with /proc. I agree that polling 
>the xt_quota2 counter and resetting at each poll will achieve the same 
>functionality but I would run tests to check that polling is actually 
>scheduled at regular enough intervals.

I still think this could be integrated, perhaps as an extra option to 
choose a particular recording mode, to xt_quota2 (including the fifo).
Speaking of which, your module seems to lack locking on the ctx, so it's 
not very consistent on SMP as of yet.

  reply	other threads:[~2011-10-04 20:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04  4:50 Packet statistics accounting module: request for comments Julien Lafaye
2011-10-04 11:02 ` Jan Engelhardt
2011-10-04 19:03   ` Julien Lafaye
2011-10-04 20:27     ` Jan Engelhardt [this message]
2011-10-05 19:27       ` Julien Lafaye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.01.1110042220390.10811@frira.zrqbmnf.qr \
    --to=jengelh@medozas.de \
    --cc=jlafaye@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.