All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@inai.de>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 06/18] netfilter: add protocol independant NAT core
Date: Thu, 23 Aug 2012 00:48:19 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.01.1208230045480.22098@frira.zrqbmnf.qr> (raw)
In-Reply-To: <Pine.GSO.4.63.1208230008220.5113@stinky-local.trash.net>


On Thursday 2012-08-23 00:13, Patrick McHardy wrote:
>>> +	iph = (void *)skb->data + iphdroff;
>>
>> Is trying to avoid some GNU extensions a worthwhile goal? If so,
>> iph = (struct iphdr *)(skb->data + iphdroff) should be used, like in:
>
> I don't get your point.

You are doing arithmetic with a void* pointer, which is a GNU extension.
Should we try to limit "unnecessary excess usage" of GNU features?
You could do arithmetic with the char* that skb->data is:

 iph = (void *)(skb->data + iphdroff);

or, if more clarity is desired, the more verbose form

 iph = (struct iphdr *)(skb->data + iphdroff);

Does this seem like something worthwhile to passively pursue?

  reply	other threads:[~2012-08-22 22:48 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20  3:39 [PATCH 00/18] netfilter: IPv6 NAT Patrick McHardy
2012-08-20  3:39 ` [PATCH 01/18] ipv4: fix path MTU discovery with connection tracking Patrick McHardy
2012-08-20  7:41   ` Eric Dumazet
2012-08-20  8:04   ` Jan Engelhardt
2012-08-20 10:59     ` Patrick McHardy
2012-08-20  3:39 ` [PATCH 02/18] netfilter: nf_conntrack_ipv6: improve fragmentation handling Patrick McHardy
2012-08-20  3:39 ` [PATCH 03/18] netfilter: nf_conntrack_ipv6: fix tracking of ICMPv6 error messages containing fragments Patrick McHardy
2012-08-20  3:39 ` [PATCH 04/18] netfilter: nf_conntrack: restrict NAT helper invocation to IPv4 Patrick McHardy
2012-08-20  3:39 ` [PATCH 05/18] netfilter: nf_nat: add protoff argument to packet mangling functions Patrick McHardy
2012-08-20  8:02   ` Jan Engelhardt
2012-08-20 10:37     ` Patrick McHardy
2012-08-20  3:39 ` [PATCH 06/18] netfilter: add protocol independant NAT core Patrick McHardy
2012-08-20  8:57   ` Jan Engelhardt
2012-08-22 22:13     ` Patrick McHardy
2012-08-22 22:48       ` Jan Engelhardt [this message]
2012-08-20  3:39 ` [PATCH 07/18] netfilter: ipv6: expand skb head in ip6_route_me_harder after oif change Patrick McHardy
2012-08-20  3:39 ` [PATCH 08/18] net: core: add function for incremental IPv6 pseudo header checksum updates Patrick McHardy
2012-08-22  9:28   ` David Miller
2012-08-20  3:39 ` [PATCH 09/18] netfilter: ipv6: add IPv6 NAT support Patrick McHardy
2012-08-20  9:03   ` Jan Engelhardt
2012-08-22 22:15     ` Patrick McHardy
2012-08-20  3:39 ` [PATCH 10/18] netfilter: ip6tables: add MASQUERADE target Patrick McHardy
2012-08-20  3:39 ` [PATCH 11/18] netfilter: ip6tables: add REDIRECT target Patrick McHardy
2012-08-20  3:40 ` [PATCH 12/18] netfilter: ip6tables: add NETMAP target Patrick McHardy
2012-08-20  3:40 ` [PATCH 13/18] netfilter: nf_nat: support IPv6 in FTP NAT helper Patrick McHardy
2012-08-20  3:40 ` [PATCH 14/18] netfilter: nf_nat: support IPv6 in amanda " Patrick McHardy
2012-08-20  3:40 ` [PATCH 15/18] netfilter: nf_nat: support IPv6 in SIP " Patrick McHardy
2012-08-20  3:40 ` [PATCH 16/18] netfilter: nf_nat: support IPv6 in IRC " Patrick McHardy
2012-08-20  3:40 ` [PATCH 17/18] netfilter: nf_nat: support IPv6 in TFTP " Patrick McHardy
2012-08-20  3:40 ` [PATCH 18/18] netfilter: ip6tables: add stateless IPv6-to-IPv6 Network Prefix Translation target Patrick McHardy
2012-08-22  9:28 ` [PATCH 00/18] netfilter: IPv6 NAT David Miller
2012-08-22 21:23   ` Patrick McHardy
2012-08-22 21:42     ` David Miller
2012-08-22 22:21       ` Patrick McHardy
2012-08-22 22:22       ` Pablo Neira Ayuso
2012-08-31  9:29 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.01.1208230045480.22098@frira.zrqbmnf.qr \
    --to=jengelh@inai.de \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.