From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751931AbeDJBf1 (ORCPT ); Mon, 9 Apr 2018 21:35:27 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:42212 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767AbeDJBf0 (ORCPT ); Mon, 9 Apr 2018 21:35:26 -0400 Date: Tue, 10 Apr 2018 11:35:13 +1000 (AEST) From: Finn Thain To: Geert Uytterhoeven cc: Laurent Vivier , Jens Axboe , linux-m68k , Linux Kernel Mailing List Subject: Re: [PATCH 03/12] m68k/mac: Don't remap SWIM MMIO region In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Apr 2018, Geert Uytterhoeven wrote: > Hi Finn, > > On Sun, Apr 1, 2018 at 3:41 AM, Finn Thain > wrote: > > For reasons I don't understand, calling ioremap() then iounmap() on > > the SWIM MMIO region causes a hang on 68030 (but not on 68040). > > Michael Schmitz also notices strange things with ioremap() on '030. > > > There's no need to call ioremap() for the SWIM address range, as it > > lies within the usual IO device region at 0x5000 0000, which is > > already mapped. > > by head.S, right? > Right. I'll mention that in the commit log when I re-submit this series. > > --- a/drivers/block/swim.c > > +++ b/drivers/block/swim.c > > @@ -911,7 +911,7 @@ static int swim_probe(struct platform_device *dev) > > goto out; > > } > > > > - swim_base = ioremap(res->start, resource_size(res)); > > + swim_base = (struct swim __iomem *)res->start; > > I guess you need a __force to please sparse? > No, sparse did not find any new issues. It appears there's an old issue elsewhere in the driver though. I'll prepare a new patch for that. -- > Gr{oetje,eeting}s, > > Geert > > --