From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751978AbeDJB2F (ORCPT ); Mon, 9 Apr 2018 21:28:05 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:41986 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbeDJB2E (ORCPT ); Mon, 9 Apr 2018 21:28:04 -0400 Date: Tue, 10 Apr 2018 11:27:51 +1000 (AEST) From: Finn Thain To: Geert Uytterhoeven cc: Laurent Vivier , Jens Axboe , linux-m68k , Linux Kernel Mailing List Subject: Re: [PATCH 08/12] block/swim: Don't log an error message for an invalid ioctl In-Reply-To: Message-ID: References: <803fabab1f0349bafe52b5589eff3edc077eee2d.1522546571.git.fthain@telegraphics.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Apr 2018, Geert Uytterhoeven wrote: > On Sun, Apr 1, 2018 at 3:41 AM, Finn Thain wrote: > > The 'eject' shell command may send various different ioctl commands. > > This leads to error messages on the console even though the FDEJECT > > ioctl succeeds. > > > > ~# eject floppy > > SWIM floppy_ioctl: unknown cmd 21257 > > SWIM floppy_ioctl: unknown cmd 1 > > > > Don't log an error message for an invalid ioctl, just do as the > > swim3 driver does and return -ENOTTY. > > > > Cc: Laurent Vivier > > Cc: Jens Axboe > > Tested-by: Stan Johnson > > Signed-off-by: Finn Thain > > Reviewed-by: Geert Uytterhoeven > > Looks like amiflop can use a similar fix. > Right. I'll prepare a new patch for that and send it separately. -- > Gr{oetje,eeting}s, > > Geert > >