From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752235AbeEKD3B (ORCPT ); Thu, 10 May 2018 23:29:01 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:39192 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbeEKD27 (ORCPT ); Thu, 10 May 2018 23:28:59 -0400 Date: Fri, 11 May 2018 13:28:57 +1000 (AEST) From: Finn Thain To: Michael Schmitz cc: Geert Uytterhoeven , "David S. Miller" , linux-m68k , netdev , Linux Kernel Mailing List , Christoph Hellwig Subject: Re: [PATCH net] macmace: Set platform device coherent_dma_mask In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 May 2018, Michael Schmitz wrote: > > > Which begs the question: why can' you set up all Nubus bus devices' > > > DMA masks in nubus_device_register(), or nubus_add_board()? > > > > I am expecting to see the same WARNING from the nubus sonic driver but > > it hasn't happened yet, so I don't have a patch for it yet. In > > anycase, the nubus fix would be a lot like the zorro bus fix, so I > > don't see a problem. > > That's odd. But what I meant to say is that by setting up > dma_coherent_mask in nubus_add_board(), and pointing dma_mask to that, > ypu won't need any patches to Nubus device drivers. Right. I think I've already acknowledged that. But it's off-topic, because the patches under review are for platform drivers. Those patches fix an actual bug that I've observed. Whereas, the nubus driver dma mask issue that you raised is purely theoretical at this stage. -- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Subject: Re: [PATCH net] macmace: Set platform device coherent_dma_mask Date: Fri, 11 May 2018 13:28:57 +1000 (AEST) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Geert Uytterhoeven , "David S. Miller" , linux-m68k , netdev , Linux Kernel Mailing List , Christoph Hellwig To: Michael Schmitz Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, 11 May 2018, Michael Schmitz wrote: > > > Which begs the question: why can' you set up all Nubus bus devices' > > > DMA masks in nubus_device_register(), or nubus_add_board()? > > > > I am expecting to see the same WARNING from the nubus sonic driver but > > it hasn't happened yet, so I don't have a patch for it yet. In > > anycase, the nubus fix would be a lot like the zorro bus fix, so I > > don't see a problem. > > That's odd. But what I meant to say is that by setting up > dma_coherent_mask in nubus_add_board(), and pointing dma_mask to that, > ypu won't need any patches to Nubus device drivers. Right. I think I've already acknowledged that. But it's off-topic, because the patches under review are for platform drivers. Those patches fix an actual bug that I've observed. Whereas, the nubus driver dma mask issue that you raised is purely theoretical at this stage. --