From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A43A9C2D0EA for ; Wed, 8 Apr 2020 08:42:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 758D020747 for ; Wed, 8 Apr 2020 08:42:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bO3zT5Vm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 758D020747 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0470A6E9B4; Wed, 8 Apr 2020 08:42:10 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 587436E9B4 for ; Wed, 8 Apr 2020 08:42:08 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id y24so441010wma.4 for ; Wed, 08 Apr 2020 01:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=T9hbX4JgRwpxhzYd2prKrjcm1764na5tkGGTN0C9OI8=; b=bO3zT5Vm1cA2sQ1FPHWz1oari6d0OxcuyWF/i5Rp6EYQliGI2n9thjt12IP4dgVYHb rn5+VsPoKfrqz0hLR6dHK436XZmZZCb4/BexL5CZbfx9Ed+lAfoAVdDvYzt2BLEXIBRj tWZxhlACsBrRqOj0W+mSFItLrqJVPxaV8DRK7mRFWIUuaXYSfQwvHsS89UeJcz7wL2hx IUQNs7k08vjY1uMy5NiQNKsOVDMgy8l1nlRxQazwkHwj36ReN8DpjppQs8THN4Nc19J1 GNWISNNS9EOTAkh3yPG+EKY4TsNptZM2wctWblZiHLhQ2VZRTE8ZIMTFu04HsJb0IOgS ervg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=T9hbX4JgRwpxhzYd2prKrjcm1764na5tkGGTN0C9OI8=; b=sAog9k/3bi63DBToYdOpeunIOsUwiDz4Bb3GAFnVumoQQW61VkhIvFhN5zwC43Zaxa GOTD6s+IxhkwjNNQXJ+arz2aCgzpyBBJacqfEUI08CFSu4zLFBrRj2SOwGy/NMiynnmW 79cNyj31jSTajJqyrdkD8lDSFjukgXzAbWv133KgCIKaraRbMiiVU1Fc7NKi8rUNDXLm ABFaD2JT8XcpZ7it1T6+fJQ3ba3NktU34D7NFK23KCzLa9tpObSs2ZlJHcKwYvMfEXA/ ci5E5IE1ORCnLKfveBacdAsc3F9TtsMF2A1gf0vHYP7qw/GRSSUW/2VrF9gVVtDotRsg kraQ== X-Gm-Message-State: AGi0Pub/ZByFok6BmjqfdkeQuthTsKk7Tj/vlSTqpgjdBOu7jkxU9lzU q1tk2kxRQ8B8hl6pcRte0Cme9kX8 X-Google-Smtp-Source: APiQypKjW3uZKD3Xp1qVdX3muWQhmxCCSJzNuDURQey8QnUo/oIcW+a01gYBcGZiPFWXNtHFHsHHRg== X-Received: by 2002:a1c:5f56:: with SMTP id t83mr3357040wmb.61.1586335327071; Wed, 08 Apr 2020 01:42:07 -0700 (PDT) Received: from wambui.local ([197.237.61.225]) by smtp.googlemail.com with ESMTPSA id j5sm4700223wrm.76.2020.04.08.01.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2020 01:42:06 -0700 (PDT) From: Wambui Karuga X-Google-Original-From: Wambui Karuga Date: Wed, 8 Apr 2020 11:42:03 +0300 (EAT) To: Jani Nikula In-Reply-To: <20200402114819.17232-12-jani.nikula@intel.com> Message-ID: References: <20200402114819.17232-1-jani.nikula@intel.com> <20200402114819.17232-12-jani.nikula@intel.com> User-Agent: Alpine 2.21.99999 (LNX 375 2019-10-29) MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 12/17] drm/i915/pmu: prefer struct drm_device based logging X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 2 Apr 2020, Jani Nikula wrote: > Prefer struct drm_device based logging over struct device based logging. > > No functional changes. > > Cc: Wambui Karuga > Signed-off-by: Jani Nikula Reviewed-by: Wambui Karuga > --- > drivers/gpu/drm/i915/i915_pmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c > index 2c062534eac1..230e9256ab30 100644 > --- a/drivers/gpu/drm/i915/i915_pmu.c > +++ b/drivers/gpu/drm/i915/i915_pmu.c > @@ -1115,7 +1115,7 @@ void i915_pmu_register(struct drm_i915_private *i915) > int ret = -ENOMEM; > > if (INTEL_GEN(i915) <= 2) { > - dev_info(i915->drm.dev, "PMU not supported for this GPU."); > + drm_info(&i915->drm, "PMU not supported for this GPU."); > return; > } > > @@ -1178,7 +1178,7 @@ void i915_pmu_register(struct drm_i915_private *i915) > if (!is_igp(i915)) > kfree(pmu->name); > err: > - dev_notice(i915->drm.dev, "Failed to register PMU!\n"); > + drm_notice(&i915->drm, "Failed to register PMU!\n"); > } > > void i915_pmu_unregister(struct drm_i915_private *i915) > -- > 2.20.1 > > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx