From: Finn Thain <fthain@telegraphics.com.au>
To: himanshu.madhani@oracle.com
Cc: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, Daniel Wagner <dwagner@suse.de>,
Nilesh Javali <njavali@marvell.com>,
Quinn Tran <qutran@marvell.com>, Martin Wilck <mwilck@suse.com>,
Roman Bolshakov <r.bolshakov@yadro.com>
Subject: Re: [PATCH v4 10/11] qla2xxx: Fix endianness annotations in header files
Date: Tue, 28 Apr 2020 10:25:10 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.22.394.2004281017310.12@nippy.intranet> (raw)
In-Reply-To: <8ca5292e-88c6-ecb3-77b7-bd6735f5ccca@oracle.com>
On Mon, 27 Apr 2020, himanshu.madhani@oracle.com wrote:
>
> This looks okay, but i would strongly suggest driver maintainer to
> verify if this introduces any regression or not.
If the changes don't affect code generation, regression is impossible.
So, compilers (and cross-compilers) could answer your question, if they
could achieve sufficient code coverage.
It would be nice if there was a tag that could be added to a patch so that
CI services could check for compiler output invariance (.s or .i or both).
>
> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
>
next prev parent reply other threads:[~2020-04-28 0:25 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 3:02 [PATCH v4 00/11] Fix qla2xxx endianness annotations Bart Van Assche
2020-04-27 3:03 ` [PATCH v4 01/11] qla2xxx: Fix spelling of a variable name Bart Van Assche
2020-04-27 8:10 ` Daniel Wagner
2020-04-27 14:09 ` himanshu.madhani
2020-05-06 12:30 ` Hannes Reinecke
2020-05-11 7:31 ` Arun Easi
2020-04-27 3:03 ` [PATCH v4 02/11] qla2xxx: Suppress two recently introduced compiler warnings Bart Van Assche
2020-04-27 8:15 ` Daniel Wagner
2020-04-27 17:37 ` Bart Van Assche
2020-04-27 18:41 ` Steven Rostedt
2020-04-30 7:29 ` Daniel Wagner
2020-04-27 14:10 ` himanshu.madhani
2020-05-06 13:41 ` Hannes Reinecke
2020-05-11 7:32 ` Arun Easi
2020-04-27 3:03 ` [PATCH v4 03/11] qla2xxx: Sort BUILD_BUG_ON() statements alphabetically Bart Van Assche
2020-04-27 8:16 ` Daniel Wagner
2020-04-27 14:11 ` himanshu.madhani
2020-05-06 13:42 ` Hannes Reinecke
2020-05-11 7:32 ` Arun Easi
2020-04-27 3:03 ` [PATCH v4 04/11] qla2xxx: Add more BUILD_BUG_ON() statements Bart Van Assche
2020-04-27 8:18 ` Daniel Wagner
2020-04-27 14:18 ` himanshu.madhani
2020-05-06 13:42 ` Hannes Reinecke
2020-05-11 7:34 ` Arun Easi
2020-05-11 15:55 ` Bart Van Assche
2020-04-27 3:03 ` [PATCH v4 05/11] qla2xxx: Make a gap in struct qla2xxx_offld_chain explicit Bart Van Assche
2020-04-27 8:26 ` Daniel Wagner
2020-04-27 14:27 ` himanshu.madhani
2020-04-27 17:39 ` Bart Van Assche
2020-05-06 13:43 ` Hannes Reinecke
2020-05-11 7:34 ` Arun Easi
2020-04-27 3:03 ` [PATCH v4 06/11] qla2xxx: Increase the size of struct qla_fcp_prio_cfg to FCP_PRIO_CFG_SIZE Bart Van Assche
2020-04-27 8:33 ` Daniel Wagner
2020-04-27 14:28 ` himanshu.madhani
2020-05-06 13:43 ` Hannes Reinecke
2020-05-11 7:36 ` Arun Easi
2020-05-11 16:04 ` Bart Van Assche
2020-04-27 3:03 ` [PATCH v4 07/11] qla2xxx: Change two hardcoded constants into offsetof() / sizeof() expressions Bart Van Assche
2020-04-27 8:39 ` Daniel Wagner
2020-04-27 14:34 ` himanshu.madhani
2020-05-06 13:45 ` Hannes Reinecke
2020-05-11 7:36 ` Arun Easi
2020-04-27 3:03 ` [PATCH v4 08/11] qla2xxx: Fix the code that reads from mailbox registers Bart Van Assche
2020-04-27 8:41 ` Daniel Wagner
2020-04-27 14:45 ` himanshu.madhani
2020-05-06 14:03 ` Hannes Reinecke
2020-05-11 7:39 ` Arun Easi
2020-05-11 16:07 ` Bart Van Assche
2020-04-27 3:03 ` [PATCH v4 09/11] qla2xxx: Change {RD,WRT}_REG_*() function names from upper case into lower case Bart Van Assche
2020-04-27 8:41 ` Daniel Wagner
2020-04-27 14:53 ` himanshu.madhani
2020-05-11 7:40 ` Arun Easi
2020-05-11 16:11 ` Bart Van Assche
2020-04-27 3:03 ` [PATCH v4 10/11] qla2xxx: Fix endianness annotations in header files Bart Van Assche
2020-04-27 14:57 ` himanshu.madhani
2020-04-28 0:25 ` Finn Thain [this message]
2020-04-28 13:55 ` himanshu.madhani
2020-04-27 3:03 ` [PATCH v4 11/11] qla2xxx: Fix endianness annotations in source files Bart Van Assche
2020-04-27 14:59 ` himanshu.madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.22.394.2004281017310.12@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=bvanassche@acm.org \
--cc=dwagner@suse.de \
--cc=himanshu.madhani@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mwilck@suse.com \
--cc=njavali@marvell.com \
--cc=qutran@marvell.com \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.