From: Finn Thain <fthain@telegraphics.com.au>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] net/sonic: Fix some resource leaks in error handling paths
Date: Sun, 10 May 2020 18:25:36 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.22.394.2005101738510.11@nippy.intranet> (raw)
In-Reply-To: <9d279f21-6172-5318-4e29-061277e82157@web.de>
[-- Attachment #1: Type: text/plain, Size: 1743 bytes --]
On Sun, 10 May 2020, Markus Elfring wrote:
> Christophe Jaillet proposed to complete the exception handling also for this
> function implementation.
> I find that such a software correction is qualified for this tag.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=e99332e7b4cda6e60f5b5916cf9943a79dbef902#n183
>
> Corresponding consequences can vary then according to the change
> management of involved developers.
>
Makes sense.
> > I think 'undo_probe1' is both descriptive and consistent with commit
> > 10e3cc180e64 ("net/sonic: Fix a resource leak in an error handling
> > path in 'jazz_sonic_probe()'").
>
> I can agree to this view (in principle).
>
> By the way:
> The referenced commit contains the tag “Fixes”.
> https://lore.kernel.org/patchwork/patch/1231354/
> https://lore.kernel.org/lkml/20200427061803.53857-1-christophe.jaillet@wanadoo.fr/
>
Right, I'd forgotten that. Do you know when these bugs were introduced?
> > Your suggestion, 'free_dma' is also good.
>
> Thanks for your positive feedback.
>
>
> > But coming up with good alternatives is easy.
>
> But the change acceptance can occasionally become harder.
>
The path to patch acceptance often takes surprising turns.
>
> > If every good alternative would be considered there would be no
> > obvious way to get a patch merged.
>
> I imagine that some alternatives can result in preferable solutions,
> can't they?
Naming goto labels is just painting another bikeshed. Yes, some
alternatives are preferable but it takes too long to identify them and
finding consensus is unlikely anyway, as it's a matter of taste.
WARNING: multiple messages have this Message-ID (diff)
From: Finn Thain <fthain@telegraphics.com.au>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] net/sonic: Fix some resource leaks in error handling paths
Date: Sun, 10 May 2020 08:25:36 +0000 [thread overview]
Message-ID: <alpine.LNX.2.22.394.2005101738510.11@nippy.intranet> (raw)
In-Reply-To: <9d279f21-6172-5318-4e29-061277e82157@web.de>
[-- Attachment #1: Type: text/plain, Size: 1743 bytes --]
On Sun, 10 May 2020, Markus Elfring wrote:
> Christophe Jaillet proposed to complete the exception handling also for this
> function implementation.
> I find that such a software correction is qualified for this tag.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=e99332e7b4cda6e60f5b5916cf9943a79dbef902#n183
>
> Corresponding consequences can vary then according to the change
> management of involved developers.
>
Makes sense.
> > I think 'undo_probe1' is both descriptive and consistent with commit
> > 10e3cc180e64 ("net/sonic: Fix a resource leak in an error handling
> > path in 'jazz_sonic_probe()'").
>
> I can agree to this view (in principle).
>
> By the way:
> The referenced commit contains the tag “Fixes”.
> https://lore.kernel.org/patchwork/patch/1231354/
> https://lore.kernel.org/lkml/20200427061803.53857-1-christophe.jaillet@wanadoo.fr/
>
Right, I'd forgotten that. Do you know when these bugs were introduced?
> > Your suggestion, 'free_dma' is also good.
>
> Thanks for your positive feedback.
>
>
> > But coming up with good alternatives is easy.
>
> But the change acceptance can occasionally become harder.
>
The path to patch acceptance often takes surprising turns.
>
> > If every good alternative would be considered there would be no
> > obvious way to get a patch merged.
>
> I imagine that some alternatives can result in preferable solutions,
> can't they?
Naming goto labels is just painting another bikeshed. Yes, some
alternatives are preferable but it takes too long to identify them and
finding consensus is unlikely anyway, as it's a matter of taste.
next prev parent reply other threads:[~2020-05-10 8:25 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 6:15 [PATCH] net/sonic: Fix some resource leaks in error handling paths Markus Elfring
2020-05-09 6:15 ` Markus Elfring
2020-05-09 23:45 ` Finn Thain
2020-05-09 23:45 ` Finn Thain
2020-05-10 5:30 ` Markus Elfring
2020-05-10 5:30 ` Markus Elfring
2020-05-10 8:25 ` Finn Thain [this message]
2020-05-10 8:25 ` Finn Thain
2020-05-10 9:07 ` Markus Elfring
2020-05-10 9:07 ` Markus Elfring
2020-05-11 0:28 ` Finn Thain
2020-05-11 0:28 ` Finn Thain
2020-05-11 6:48 ` Markus Elfring
2020-05-11 6:48 ` Markus Elfring
2020-05-12 0:08 ` Finn Thain
2020-05-12 0:08 ` Finn Thain
2020-05-12 6:38 ` Markus Elfring
2020-05-12 6:38 ` Markus Elfring
2020-05-13 1:14 ` Finn Thain
2020-05-13 1:14 ` Finn Thain
2020-05-13 5:07 ` net/sonic: Software evolution around the application of coding standards Markus Elfring
2020-05-13 5:07 ` Markus Elfring
2020-05-13 23:16 ` Finn Thain
2020-05-13 23:16 ` Finn Thain
2020-05-11 8:20 ` net/sonic: Fix some resource leaks in error handling paths Markus Elfring
2020-05-11 8:20 ` Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-05-08 17:25 [PATCH] " Christophe JAILLET
2020-05-08 17:25 ` Christophe JAILLET
2020-05-08 23:28 ` Finn Thain
2020-05-08 23:28 ` Finn Thain
2020-05-09 0:57 ` Jakub Kicinski
2020-05-09 0:57 ` Jakub Kicinski
2020-05-09 1:57 ` Finn Thain
2020-05-09 1:57 ` Finn Thain
2020-05-09 2:04 ` Jakub Kicinski
2020-05-09 2:04 ` Jakub Kicinski
2020-05-09 1:54 ` Jakub Kicinski
2020-05-09 1:54 ` Jakub Kicinski
2020-05-09 16:47 ` Christophe JAILLET
2020-05-09 16:47 ` Christophe JAILLET
2020-05-09 18:13 ` Jakub Kicinski
2020-05-09 18:13 ` Jakub Kicinski
2020-05-09 20:31 ` Christophe JAILLET
2020-05-09 20:31 ` Christophe JAILLET
2020-05-09 22:42 ` Joe Perches
2020-05-09 22:42 ` Joe Perches
2020-05-09 23:32 ` David Miller
2020-05-09 23:32 ` David Miller
2020-05-09 23:41 ` Joe Perches
2020-05-09 23:41 ` Joe Perches
2020-05-09 23:52 ` Finn Thain
2020-05-09 23:52 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.22.394.2005101738510.11@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=Markus.Elfring@web.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.