From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17AE3C54E4B for ; Mon, 11 May 2020 00:29:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE06B2082E for ; Mon, 11 May 2020 00:29:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729331AbgEKA2c (ORCPT ); Sun, 10 May 2020 20:28:32 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:38942 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729168AbgEKA2c (ORCPT ); Sun, 10 May 2020 20:28:32 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id AAECC299CB; Sun, 10 May 2020 20:28:27 -0400 (EDT) Date: Mon, 11 May 2020 10:28:34 +1000 (AEST) From: Finn Thain To: Markus Elfring cc: Christophe Jaillet , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski Subject: Re: net/sonic: Fix some resource leaks in error handling paths In-Reply-To: Message-ID: References: <9d279f21-6172-5318-4e29-061277e82157@web.de> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="-1463811774-1651048744-1589151508=:8" Content-ID: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811774-1651048744-1589151508=:8 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Content-ID: On Sun, 10 May 2020, Markus Elfring wrote: > > > > Do you know when these bugs were introduced? >=20 > I suggest to take another look at a provided tag =E2=80=9CFixes=E2=80=9D. If you can't determine when the bug was introduced, how can you criticise= =20 a patch for the lack of a Fixes tag? > To which commit would you like to refer to for the proposed adjustment=20 > of the function =E2=80=9Cmac_sonic_platform_probe=E2=80=9D? >=20 That was my question to you. We seem to be talking past each other.=20 Unforunately I only speak English, so if this misunderstanding is to be=20 resolved, you're going to have to try harder to make yourself understood. > > Naming goto labels is just painting another bikeshed. Yes, some=20 > > alternatives are preferable but it takes too long to identify them and= =20 > > finding consensus is unlikely anyway, as it's a matter of taste. >=20 > Would you find numbered labels unwanted according to a possible=20 > interpretation related to 'GW-BASIC' identifier selection? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D= ocumentation/process/coding-style.rst?id=3De99332e7b4cda6e60f5b5916cf9943a7= 9dbef902#n460 >=20 My preference is unimportant here. Therefore, your question must be=20 rhetorical. I presume that you mean to assert that Christophe's patch=20 breaches the style guide. However, 'sonic_probe1' is the name of a function. The name of the goto=20 label 'undo_probe1' reflects the name of the function. This is not some sequence of GW-BASIC labels referred to in the style=20 guide. And neither does the patch add new functions with numbered names. > Can programming preferences evolve into the direction of =E2=80=9Csay wha= t the=20 > goto does=E2=80=9D? >=20 I could agree that macsonic.c has no function resembling "probe1", and=20 that portion of the patch could be improved. Was that the opinion you were trying to express by way of rhetorical=20 questions? I can't tell. Is it possible for a reviewer to effectively criticise C by use of=20 English, when his C ability surpasses his English ability? You needn't answer that question, but please do consider it. > Regards, > Markus >=20 ---1463811774-1651048744-1589151508=:8-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Date: Mon, 11 May 2020 00:28:34 +0000 Subject: Re: net/sonic: Fix some resource leaks in error handling paths Message-Id: MIME-Version: 1 Content-Type: multipart/mixed; boundary="-1463811774-1651048744-1589151508=:8" List-Id: References: <9d279f21-6172-5318-4e29-061277e82157@web.de> In-Reply-To: To: Markus Elfring Cc: Christophe Jaillet , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811774-1651048744-1589151508=:8 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Content-ID: On Sun, 10 May 2020, Markus Elfring wrote: > > > > Do you know when these bugs were introduced? >=20 > I suggest to take another look at a provided tag =E2=80=9CFixes=E2=80=9D. If you can't determine when the bug was introduced, how can you criticise= =20 a patch for the lack of a Fixes tag? > To which commit would you like to refer to for the proposed adjustment=20 > of the function =E2=80=9Cmac_sonic_platform_probe=E2=80=9D? >=20 That was my question to you. We seem to be talking past each other.=20 Unforunately I only speak English, so if this misunderstanding is to be=20 resolved, you're going to have to try harder to make yourself understood. > > Naming goto labels is just painting another bikeshed. Yes, some=20 > > alternatives are preferable but it takes too long to identify them and= =20 > > finding consensus is unlikely anyway, as it's a matter of taste. >=20 > Would you find numbered labels unwanted according to a possible=20 > interpretation related to 'GW-BASIC' identifier selection? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D= ocumentation/process/coding-style.rst?id=3De99332e7b4cda6e60f5b5916cf9943a7= 9dbef902#n460 >=20 My preference is unimportant here. Therefore, your question must be=20 rhetorical. I presume that you mean to assert that Christophe's patch=20 breaches the style guide. However, 'sonic_probe1' is the name of a function. The name of the goto=20 label 'undo_probe1' reflects the name of the function. This is not some sequence of GW-BASIC labels referred to in the style=20 guide. And neither does the patch add new functions with numbered names. > Can programming preferences evolve into the direction of =E2=80=9Csay wha= t the=20 > goto does=E2=80=9D? >=20 I could agree that macsonic.c has no function resembling "probe1", and=20 that portion of the patch could be improved. Was that the opinion you were trying to express by way of rhetorical=20 questions? I can't tell. Is it possible for a reviewer to effectively criticise C by use of=20 English, when his C ability surpasses his English ability? You needn't answer that question, but please do consider it. > Regards, > Markus >=20 ---1463811774-1651048744-1589151508=:8--