From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 16/27] KVM: Move kvm_guest_init out of generic code Date: Fri, 2 Jul 2010 09:41:48 +0200 Message-ID: References: <1277980982-12433-1-git-send-email-agraf@suse.de> <1277980982-12433-17-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev , KVM list To: Alexander Graf Return-path: In-Reply-To: <1277980982-12433-17-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, 1 Jul 2010, Alexander Graf wrote: > Currently x86 is the only architecture that uses kvm_guest_init(). Wi= th > PowerPC we're getting a second user, but the signature is different t= here > and we don't need to export it, as it uses the normal kernel init fra= mework. Making the signatures match (i.e. always return `int') wouldn't hurt, since kvm_guest_init() apparently can fail on x86, too. > So let's move the x86 specific definition of that function over to th= e x86 > specfic header file. With kind regards, Geert Uytterhoeven Software Architect Techsoft Centre Technology and Software Centre Europe The Corporate Village =B7 Da Vincilaan 7-D1 =B7 B-1935 Zaventem =B7 Bel= gium Phone: +32 (0)2 700 8453 =46ax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven-osDt5Q4Chk1BDgjK7y7TUQ@public.gmane.org Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 =B7 RPR Brussels =46ortis =B7 BIC GEBABEBB =B7 IBAN BE41293037680010 ***********************************************************************= * The information contained in this message or any of its attachments may= be confidential and is intended for the exclusive use of the addressee= (s). Any disclosure, reproduction, distribution or other dissemination= or use of this communication is strictly prohibited without the expres= s permission of the sender. The views expressed in this email are thos= e of the individual and not necessarily those of Sony or Sony affiliate= d companies. Sony email is for business use only. This email and any response may be monitored by Sony to be in complianc= e with Sony's global policies and standards From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from VA3EHSOBE008.bigfish.com (va3ehsobe006.messaging.microsoft.com [216.32.180.16]) by ozlabs.org (Postfix) with ESMTP id A28B91007D2 for ; Fri, 2 Jul 2010 17:57:34 +1000 (EST) Received: from mail39-va3 (localhost.localdomain [127.0.0.1]) by mail39-va3-R.bigfish.com (Postfix) with ESMTP id 3B6B712600A2 for ; Fri, 2 Jul 2010 07:42:13 +0000 (UTC) Received: from VA3EHSMHS023.bigfish.com (unknown [10.7.14.238]) by mail39-va3.bigfish.com (Postfix) with ESMTP id BC02E10B804F for ; Fri, 2 Jul 2010 07:42:12 +0000 (UTC) Received: from [43.194.30.232] ([43.194.30.232]:29324 "EHLO wymx1.eu.sony.com") by mx3.eu.sony.com with ESMTP id S54771Ab0GBHlu (ORCPT ); Fri, 2 Jul 2010 08:41:50 +0100 Received: from gb-bas-dc-dx1.eu.sony.com ([43.194.30.31]:8761 "EHLO gbise0weymsx02.eu.sony.com") by wymx1.eu.sony.com with ESMTP id S54807Ab0GBHlu convert rfc822-to-8bit (ORCPT ); Fri, 2 Jul 2010 08:41:50 +0100 Date: Fri, 2 Jul 2010 09:41:48 +0200 From: Geert Uytterhoeven Sender: To: Alexander Graf Subject: Re: [PATCH 16/27] KVM: Move kvm_guest_init out of generic code In-Reply-To: <1277980982-12433-17-git-send-email-agraf@suse.de> Message-ID: References: <1277980982-12433-1-git-send-email-agraf@suse.de> <1277980982-12433-17-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Cc: linuxppc-dev , KVM list , kvm-ppc@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 1 Jul 2010, Alexander Graf wrote: > Currently x86 is the only architecture that uses kvm_guest_init(). With > PowerPC we're getting a second user, but the signature is different there= > and we don't need to export it, as it uses the normal kernel init framewo= rk. Making the signatures match (i.e. always return `int') wouldn't hurt, since kvm_guest_init() apparently can fail on x86, too. > So let's move the x86 specific definition of that function over to the x8= 6 > specfic header file. With kind regards, Geert Uytterhoeven Software Architect Techsoft Centre Technology and Software Centre Europe The Corporate Village =B7 Da Vincilaan 7-D1 =B7 B-1935 Zaventem =B7 Belgium= Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 =B7 RPR Brussels Fortis =B7 BIC GEBABEBB =B7 IBAN BE41293037680010 ************************************************************************ The information contained in this message or any of its attachments may be = confidential and is intended for the exclusive use of the addressee(s). An= y disclosure, reproduction, distribution or other dissemination or use of t= his communication is strictly prohibited without the express permission of = the sender. The views expressed in this email are those of the individual = and not necessarily those of Sony or Sony affiliated companies. Sony email= is for business use only. This email and any response may be monitored by Sony to be in compliance wi= th Sony's global policies and standards From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Fri, 02 Jul 2010 07:41:48 +0000 Subject: Re: [PATCH 16/27] KVM: Move kvm_guest_init out of generic code Message-Id: List-Id: References: <1277980982-12433-1-git-send-email-agraf@suse.de> <1277980982-12433-17-git-send-email-agraf@suse.de> In-Reply-To: <1277980982-12433-17-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="ks_c_5601-1987" Content-Transfer-Encoding: base64 To: Alexander Graf Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev , KVM list T24gVGh1LCAxIEp1bCAyMDEwLCBBbGV4YW5kZXIgR3JhZiB3cm90ZToKPiBDdXJyZW50bHkgeDg2 IGlzIHRoZSBvbmx5IGFyY2hpdGVjdHVyZSB0aGF0IHVzZXMga3ZtX2d1ZXN0X2luaXQoKS4gV2l0 aAo+IFBvd2VyUEMgd2UncmUgZ2V0dGluZyBhIHNlY29uZCB1c2VyLCBidXQgdGhlIHNpZ25hdHVy ZSBpcyBkaWZmZXJlbnQgdGhlcmUKPiBhbmQgd2UgZG9uJ3QgbmVlZCB0byBleHBvcnQgaXQsIGFz IGl0IHVzZXMgdGhlIG5vcm1hbCBrZXJuZWwgaW5pdCBmcmFtZXdvcmsuCgpNYWtpbmcgdGhlIHNp Z25hdHVyZXMgbWF0Y2ggKGkuZS4gYWx3YXlzIHJldHVybiBgaW50Jykgd291bGRuJ3QgaHVydCwK c2luY2Uga3ZtX2d1ZXN0X2luaXQoKSBhcHBhcmVudGx5IGNhbiBmYWlsIG9uIHg4NiwgdG9vLgoK PiBTbyBsZXQncyBtb3ZlIHRoZSB4ODYgc3BlY2lmaWMgZGVmaW5pdGlvbiBvZiB0aGF0IGZ1bmN0 aW9uIG92ZXIgdG8gdGhlIHg4Ngo+IHNwZWNmaWMgaGVhZGVyIGZpbGUuCgpXaXRoIGtpbmQgcmVn YXJkcywKCkdlZXJ0IFV5dHRlcmhvZXZlbgpTb2Z0d2FyZSBBcmNoaXRlY3QKVGVjaHNvZnQgQ2Vu dHJlCgpUZWNobm9sb2d5IGFuZCBTb2Z0d2FyZSBDZW50cmUgRXVyb3BlClRoZSBDb3Jwb3JhdGUg VmlsbGFnZSC3IERhIFZpbmNpbGFhbiA3LUQxILcgQi0xOTM1IFphdmVudGVtILcgQmVsZ2l1bQoK UGhvbmU6ICAgICszMiAoMCkyIDcwMCA4NDUzCkZheDogICAgICArMzIgKDApMiA3MDAgODYyMgpF LW1haWw6ICAgR2VlcnQuVXl0dGVyaG9ldmVuQHNvbnljb20uY29tCkludGVybmV0OiBodHRwOi8v d3d3LnNvbnktZXVyb3BlLmNvbS8KCkEgZGl2aXNpb24gb2YgU29ueSBFdXJvcGUgKEJlbGdpdW0p IE4uVi4KVkFUIEJFIDA0MTMuODI1LjE2MCC3IFJQUiBCcnVzc2VscwpGb3J0aXMgtyBCSUMgR0VC QUJFQkIgtyBJQkFOIEJFNDEyOTMwMzc2ODAwMTAKCioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKgpUaGUgaW5mb3Jt YXRpb24gY29udGFpbmVkIGluIHRoaXMgbWVzc2FnZSBvciBhbnkgb2YgaXRzIGF0dGFjaG1lbnRz IG1heSBiZSBjb25maWRlbnRpYWwgYW5kIGlzIGludGVuZGVkIGZvciB0aGUgZXhjbHVzaXZlIHVz ZSBvZiB0aGUgYWRkcmVzc2VlKHMpLiAgQW55IGRpc2Nsb3N1cmUsIHJlcHJvZHVjdGlvbiwgZGlz dHJpYnV0aW9uIG9yIG90aGVyIGRpc3NlbWluYXRpb24gb3IgdXNlIG9mIHRoaXMgY29tbXVuaWNh dGlvbiBpcyBzdHJpY3RseSBwcm9oaWJpdGVkIHdpdGhvdXQgdGhlIGV4cHJlc3MgcGVybWlzc2lv biBvZiB0aGUgc2VuZGVyLiAgVGhlIHZpZXdzIGV4cHJlc3NlZCBpbiB0aGlzIGVtYWlsIGFyZSB0 aG9zZSBvZiB0aGUgaW5kaXZpZHVhbCBhbmQgbm90IG5lY2Vzc2FyaWx5IHRob3NlIG9mIFNvbnkg b3IgU29ueSBhZmZpbGlhdGVkIGNvbXBhbmllcy4gIFNvbnkgZW1haWwgaXMgZm9yIGJ1c2luZXNz IHVzZSBvbmx5LgoKVGhpcyBlbWFpbCBhbmQgYW55IHJlc3BvbnNlIG1heSBiZSBtb25pdG9yZWQg YnkgU29ueSB0byBiZSBpbiBjb21wbGlhbmNlIHdpdGggU29ueSdzIGdsb2JhbCBwb2xpY2llcyBh bmQgc3RhbmRhcmRzCgoKLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhl IGxpbmUgInVuc3Vic2NyaWJlIGt2bS1wcGMiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBt YWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92 Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbA==