From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752362AbcHHS5I (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Aug 2016 14:57:08 -0400
Received: from twin.jikos.cz ([89.185.236.188]:45554 "EHLO twin.jikos.cz"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752176AbcHHS5H (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Aug 2016 14:57:07 -0400
Date: Mon, 8 Aug 2016 20:53:16 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
X-X-Sender: jikos@twin.jikos.cz
To: Peter Zijlstra <peterz@infradead.org>
cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Ville Syrj??l?? <ville.syrjala@linux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        Borislav Petkov <bp@suse.de>, "H . Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>, Brian Gerst <brgerst@gmail.com>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] x86/hweight: Don't clobber %rdi
In-Reply-To: <20160808183208.GB30192@twins.programming.kicks-ass.net>
Message-ID: <alpine.LRH.2.00.1608082050110.19185@gjva.wvxbf.pm>
References: <1470677729-10561-1-git-send-email-ville.syrjala@linux.intel.com> <CA+55aFzE9p7ts6EK7Hia25n=LZ+TMNDZ+uJND1GjJjZo4NLETw@mail.gmail.com> <20160808183208.GB30192@twins.programming.kicks-ass.net>
User-Agent: Alpine 2.00 (LRH 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 8 Aug 2016, Peter Zijlstra wrote:

> > > The caller expects %rdi to remain intact, push+pop it make that happen.
> > 
> > Indeed. Applied,
> 
> See also:
> 
>   lkml.kernel.org/r/alpine.LNX.2.00.1608081634530.22028@cbobk.fhfr.pm

Ville's patch is the proper thing to do; I still think the comments 
probably should be removed as they might provide more confusion than help, 
but that's a separate discussion.

Thanks,

-- 
Jiri Kosina
SUSE Labs