Re: [PATCH] NFS: Make keys writable on the idmap keyring.

From: James Morris <jmorris@namei.org>
To: Steve Dickson <steved@redhat.com>
Cc: Linux Keyring Mailing list <keyrings@linux-nfs.org>,
	Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFS: Make keys writable on the idmap keyring.
Date: Wed, 8 Feb 2012 10:29:39 +1100 (EST)	[thread overview]
Message-ID: <alpine.LRH.2.02.1202081029000.777@tundra.namei.org> (raw)
In-Reply-To: <1328619733-30859-1-git-send-email-steved@redhat.com>

Should this go in via the NFS tree?  I can put it into the security tree 
otherwise.

On Tue, 7 Feb 2012, Steve Dickson wrote:

> To take advantage of the "Allow special keyrings to be
> cleared" keyring patch the NFS keyring has to be writeable.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
>  fs/nfs/idmap.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
> index a1bbf77..1d88cdb 100644
> --- a/fs/nfs/idmap.c
> +++ b/fs/nfs/idmap.c
> @@ -269,7 +269,7 @@ static ssize_t nfs_idmap_request_key(const char *name, size_t namelen,
>  	}
>  
>  	rcu_read_lock();
> -	rkey->perm |= KEY_USR_VIEW;
> +	rkey->perm |= KEY_USR_VIEW|KEY_USR_WRITE;
>  
>  	ret = key_validate(rkey);
>  	if (ret < 0)
> -- 
> 1.7.7.5
> 

-- 
James Morris
<jmorris@namei.org>