From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikulas Patocka Subject: Re: [PATCH] dm-bufio: move dm-bufio.h to include/linux/ Date: Thu, 8 Mar 2018 22:56:18 -0500 (EST) Message-ID: References: <20180308144955.GA23262@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180308144955.GA23262@infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Christoph Hellwig Cc: Mike Snitzer , dm-devel@redhat.com, Thomas Jaskiewicz List-Id: dm-devel.ids On Thu, 8 Mar 2018, Christoph Hellwig wrote: > On Thu, Mar 08, 2018 at 04:22:01AM -0500, Mikulas Patocka wrote: > > This patch moves dm-bufio to include/linux/, so that external modules can > > use it. (it is needed for the VDO team) > > NAK. We have include/linux/device-mapper.h, include/linux/dm-io.h, include/linux/dm-kcopyd.h, include/linux/dm-region-hash.h, include/linux/dm-dirty-log.h. So why not include/linux/dm-bufio.h? BTW. dm-bufio doesn't really depend on device mapper at all and it could be used by non-dm drivers as well. > That code once merged should just move to drivers/md/. But that mering will take a lot of time and until it happens, it will be distributed as a separate module. Mikulas