From: Mikulas Patocka <mpatocka@redhat.com>
To: Melvin Vermeeren <vermeeren@vermwa.re>
Cc: Mike Snitzer <msnitzer@redhat.com>,
dm-devel@redhat.com, Milan Broz <mbroz@redhat.com>
Subject: Re: [dm-devel] [PATCH v2] dm-integrity: if we have discard support, use it when recalculating
Date: Wed, 5 May 2021 16:45:09 -0400 (EDT) [thread overview]
Message-ID: <alpine.LRH.2.02.2105051642300.32187@file01.intranet.prod.int.rdu2.redhat.com> (raw)
In-Reply-To: <10258776.4TuPVb8Keo@verm-r4e>
On Wed, 5 May 2021, Melvin Vermeeren wrote:
> On Wednesday, 5 May 2021 22:05:35 CEST Mikulas Patocka wrote:
> > Yes.
>
> I fail to understand why that would be desired behaviour, as I see it it is
> conflicting with current documentation in integritysetup(8):
So, we can ask Milan to update the manpage.
> > --integrity-recalculate
> > Automatically recalculate integrity tags in kernel on activation. The device
> > can be used during automatic integrity recalculation but becomes fully
> > integrity protected only after the background operation is finished. This
> > option is available since the Linux kernel version 4.19.
>
> The device in SSD with discard case never receives integrity protection
> because the metadata is filled with discard filler. Could you explain the
> reasoning behind the patch?
It will receive integrity protection for the newly written data.
If you create an integrity device and make a filesystem on it, the newly
written data matters. The old data that were on the filesystem before
formatting it don't care and don't need to be protected.
> Thanks,
Mikulas
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-05-05 20:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 21:00 [dm-devel] [PATCH v2] dm-integrity: if we have discard support, use it when recalculating Mikulas Patocka
2021-04-30 19:39 ` Melvin Vermeeren
2021-05-05 18:48 ` Mikulas Patocka
2021-05-05 19:27 ` Melvin Vermeeren
2021-05-05 20:05 ` Mikulas Patocka
2021-05-05 20:16 ` Melvin Vermeeren
2021-05-05 20:45 ` Mikulas Patocka [this message]
2021-05-05 21:47 ` Melvin Vermeeren
2021-05-11 17:06 ` Milan Broz
2021-05-11 18:33 ` Melvin Vermeeren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.02.2105051642300.32187@file01.intranet.prod.int.rdu2.redhat.com \
--to=mpatocka@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mbroz@redhat.com \
--cc=msnitzer@redhat.com \
--cc=vermeeren@vermwa.re \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.